Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use common OIDC token env vars in post scripts #23549

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Use common OIDC token env vars in post scripts #23549

merged 2 commits into from
Oct 10, 2024

Conversation

benbp
Copy link
Member

@benbp benbp commented Oct 4, 2024 •
edited
Loading

This should fix the weekly pipelines for azidentity and azcontainerregistry (this one still fails, but it's not engsys' fault anymore).

Relies on Azure/azure-sdk-tools#9099 going in first.

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Oct 4, 2024
@benbp benbp requested review from a team and richardpark-msft as code owners October 4, 2024 23:02
@benbp benbp self-assigned this Oct 4, 2024
This was referenced Oct 4, 2024
Merged
Merged
@chlowell
Copy link
Member

chlowell commented Oct 4, 2024

#23548 will green azidentity CI

RickWinter
RickWinter approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@RickWinter RickWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Please get @chlowell to review before checking in

@benbp benbp force-pushed the benbp/pre-steps-multi-cloud branch from ec65353 to 6aab9c6 Compare October 7, 2024 19:34
@benbp benbp force-pushed the benbp/pre-steps-multi-cloud branch from 6aab9c6 to ab74410 Compare October 8, 2024 17:15
@benbp
Copy link
Member Author

benbp commented Oct 8, 2024

/azp run go - azidentity

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maorleger
Copy link
Member

Any plans to do this cross-language? I am definitely interested in this for JS - keyvault and identity would both benefit 👍

@benbp
Copy link
Member Author

benbp commented Oct 8, 2024

/azp run go - azidentity

@benbp
Copy link
Member Author

benbp commented Oct 8, 2024 •
edited
Loading

Any plans to do this cross-language? I am definitely interested in this for JS - keyvault and identity would both benefit 👍

Yep! Azure/azure-sdk-for-js#31335

I didn't see any oidc usage for keyvault though, is that incoming?

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp
Copy link
Member Author

benbp commented Oct 8, 2024

/azp run go - azidentity - weekly

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp
Copy link
Member Author

benbp commented Oct 8, 2024

/azp run go - azcontainerregistry - weekly

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp
Copy link
Member Author

benbp commented Oct 8, 2024

@chlowell I'm not sure why yet, but the container registry tests do not seem to be picking up the right audience when running in sovereign cloud contexts (https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4210366&view=logs&j=6617e070-ecf6-5e84-d74f-69d70ef2cee7&t=df873bcd-9288-585c-3c23-e81f89f38ac8&l=1004). It predates these changes but may have coincided with our federated auth move.

@chlowell
Copy link
Member

chlowell commented Oct 8, 2024

There's a bug. It might predate federated auth or I might have added it 😇

Try chlowell@cf51e8b

@benbp
Copy link
Member Author

benbp commented Oct 9, 2024

/azp run go - azcontainerregistry - weekly

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp
Copy link
Member Author

benbp commented Oct 9, 2024

/azp run go - azcontainerregistry - weekly

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp benbp force-pushed the benbp/pre-steps-multi-cloud branch from cda73de to b66be01 Compare October 10, 2024 19:24
@benbp
Copy link
Member Author

benbp commented Oct 10, 2024

/azp run go - azcontainerregistry - weekly

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp
Copy link
Member Author

benbp commented Oct 10, 2024

/azp run go - azcontainerregistry - weekly

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp
Copy link
Member Author

benbp commented Oct 10, 2024

/azp run go - azidentity - weekly

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp
Copy link
Member Author

benbp commented Oct 10, 2024

/check-enforcer evaluate

@benbp benbp enabled auto-merge (squash) October 10, 2024 20:49
@benbp benbp merged commit 5df372c into Azure:main Oct 10, 2024
100 checks passed
@benbp benbp deleted the benbp/pre-steps-multi-cloud branch October 10, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlowell chlowell chlowell approved these changes

@weshaggard weshaggard weshaggard approved these changes

@RickWinter RickWinter RickWinter approved these changes

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT jhendrixMSFT is a code owner

@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft richardpark-msft is a code owner

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner automatically assigned from Azure/azure-sdk-write-identity

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner automatically assigned from Azure/azure-sdk-write-identity

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees

@benbp benbp

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benbp @chlowell @maorleger @RickWinter @weshaggard