-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CECO-1860][DatadogGenericResource] Refactor handler #1634
base: main
Are you sure you want to change the base?
Conversation
@@ -65,6 +66,9 @@ func Test_handleFinalizer(t *testing.T) { | |||
Finalizers: []string{datadogGenericResourceFinalizer}, | |||
DeletionTimestamp: &metaNow, | |||
}, | |||
Spec: datadoghqv1alpha1.DatadogGenericResourceSpec{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is necessary as the switch case for deletion handler now panics on unsupported/empty resource type
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1634 +/- ##
==========================================
+ Coverage 48.93% 48.96% +0.02%
==========================================
Files 217 217
Lines 20892 20880 -12
==========================================
Hits 10223 10223
+ Misses 10129 10117 -12
Partials 540 540
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
… (and associated test)
What does this PR do?
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Same instructions as #1534, can use
config/samples/datadoghq_v1alpha1_datadoggenericresource.yaml
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label