Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ostruct gem out from test group for Ruby 3.5 #4287

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

y9v
Copy link
Member

@y9v y9v commented Jan 14, 2025

Apparently ostruct gem is removed by bundle clean before the memory leak check.

What does this PR do?
This PR moves ostruct gem out from the test group.

Motivation:
CI failing:
https://github.com/DataDog/dd-trace-rb/actions/runs/12713392872/job/35441183658?pr=4236

Change log entry
None.

Additional Notes:
None.

How to test the change?
CI is enough

@y9v y9v self-assigned this Jan 14, 2025
@y9v y9v requested a review from a team as a code owner January 14, 2025 18:51
OStruct was extracted to a gem in Ruby 3.5 and we use Ruby 3.5 to run a
test for memory leaks
@y9v y9v force-pushed the add-ostruct-gem-to-ruby-3-5-gemfile branch from 44be9d9 to ecf6a2b Compare January 14, 2025 18:53
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 14, 2025

Datadog Report

Branch report: add-ostruct-gem-to-ruby-3-5-gemfile
Commit report: ecf6a2b
Test service: dd-trace-rb

✅ 0 Failed, 22186 Passed, 1476 Skipped, 5m 23.82s Total Time

@y9v y9v changed the title Add ostruct gem to Ruby 3.5 gemfile Move ostruct gem out from test group for Ruby 3.5 Jan 14, 2025
@y9v y9v changed the title Move ostruct gem out from test group for Ruby 3.5 Move ostruct gem out from test group for Ruby 3.5 Jan 14, 2025
@y9v y9v enabled auto-merge January 14, 2025 19:07
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (5235204) to head (ecf6a2b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4287      +/-   ##
==========================================
- Coverage   97.72%   97.71%   -0.02%     
==========================================
  Files        1354     1354              
  Lines       82410    82410              
  Branches     4213     4213              
==========================================
- Hits        80538    80525      -13     
- Misses       1872     1885      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 14, 2025

Benchmarks

Benchmark execution time: 2025-01-14 19:19:14

Comparing candidate commit ecf6a2b in PR branch add-ostruct-gem-to-ruby-3-5-gemfile with baseline commit 5235204 in branch master.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics.

scenario:tracing - 100 span trace - no writer

  • 🟩 throughput [+17.044op/s; +17.884op/s] or [+5.157%; +5.411%]

scenario:tracing - Propagation - Datadog

  • 🟩 throughput [+3619.499op/s; +3695.877op/s] or [+12.139%; +12.395%]

scenario:tracing - Tracing.log_correlation

  • 🟩 throughput [+7183.597op/s; +7603.163op/s] or [+6.559%; +6.942%]

@y9v y9v merged commit b2bf14b into master Jan 14, 2025
392 checks passed
@y9v y9v deleted the add-ostruct-gem-to-ruby-3-5-gemfile branch January 14, 2025 19:20
@github-actions github-actions bot added this to the 2.9.0 milestone Jan 14, 2025
@ivoanjo
Copy link
Member

ivoanjo commented Jan 15, 2025

Thanks for fixing this -- I think an alternative could be to tweak the bundle install that we use to install the test group, but I think this option works well too. (Especially given nothing else is using Ruby 3.5 on our tests yet. Seems so far away, 3.5 haha ... the future)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants