-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ostruct
gem out from test group for Ruby 3.5
#4287
Conversation
OStruct was extracted to a gem in Ruby 3.5 and we use Ruby 3.5 to run a test for memory leaks
44be9d9
to
ecf6a2b
Compare
Datadog ReportBranch report: ✅ 0 Failed, 22186 Passed, 1476 Skipped, 5m 23.82s Total Time |
ostruct
gem out from test group for Ruby 3.5
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4287 +/- ##
==========================================
- Coverage 97.72% 97.71% -0.02%
==========================================
Files 1354 1354
Lines 82410 82410
Branches 4213 4213
==========================================
- Hits 80538 80525 -13
- Misses 1872 1885 +13 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2025-01-14 19:19:14 Comparing candidate commit ecf6a2b in PR branch Found 3 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics. scenario:tracing - 100 span trace - no writer
scenario:tracing - Propagation - Datadog
scenario:tracing - Tracing.log_correlation
|
Thanks for fixing this -- I think an alternative could be to tweak the bundle install that we use to install the test group, but I think this option works well too. (Especially given nothing else is using Ruby 3.5 on our tests yet. Seems so far away, 3.5 haha ... the future) |
Apparently
ostruct
gem is removed bybundle clean
before the memory leak check.What does this PR do?
This PR moves
ostruct
gem out from the test group.Motivation:
CI failing:
https://github.com/DataDog/dd-trace-rb/actions/runs/12713392872/job/35441183658?pr=4236
Change log entry
None.
Additional Notes:
None.
How to test the change?
CI is enough