fix(whale-api): add reindex for failed to indexed block #2169

lykalabrada · 2023-11-07T02:00:23Z

What this PR does / why we need it:

Fixing random bug !bestChain

introduce status reindex to jump off the cleanup cycle if NotFoundIndexError
logged on random bug!bestChain

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

netlify · 2023-11-07T02:00:28Z

✅ Deploy Preview for jellyfishsdk ready!

Name	Link
🔨 Latest commit	`3883065`
🔍 Latest deploy log	https://app.netlify.com/sites/jellyfishsdk/deploys/654dc942565c2b00094c8bda
😎 Deploy Preview	https://deploy-preview-2169--jellyfishsdk.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2023-11-07T02:08:29Z

Codecov Report

Merging #2169 (3883065) into main (6f312b9) will increase coverage by 1.12%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #2169      +/-   ##
==========================================
+ Coverage   90.86%   91.99%   +1.12%     
==========================================
  Files         366      371       +5     
  Lines       11069    11243     +174     
  Branches     1448     1474      +26     
==========================================
+ Hits        10058    10343     +285     
+ Misses        970      864     -106     
+ Partials       41       36       -5

Files	Coverage Δ
apps/whale-api/src/module.indexer/status.ts	`100.00% <100.00%> (ø)`
...whale-api/src/module.indexer/rpc.block.provider.ts	`86.66% <50.00%> (-2.62%)`	⬇️

... and 89 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

github-actions · 2023-11-07T02:15:50Z

Docker build preview for jellyfish/apps is ready!

Built with commit e89e5e6

ghcr.io/birthdayresearch/legacy-api:pr-2169
ghcr.io/birthdayresearch/playground-api:pr-2169
ghcr.io/birthdayresearch/status-api:pr-2169
ghcr.io/birthdayresearch/whale-api:pr-2169

You can also get an immutable image with the commit hash

ghcr.io/birthdayresearch/legacy-api:e89e5e6e97c0f63e88a4acfad4573530c26503c6
ghcr.io/birthdayresearch/playground-api:e89e5e6e97c0f63e88a4acfad4573530c26503c6
ghcr.io/birthdayresearch/status-api:e89e5e6e97c0f63e88a4acfad4573530c26503c6
ghcr.io/birthdayresearch/whale-api:e89e5e6e97c0f63e88a4acfad4573530c26503c6

canonbrother · 2023-11-10T03:32:17Z

@lykalabrada
suggestion:

-- await this.statusMapper.put(hash, height, Status.ERROR)
++ if (err instanceof NotFoundIndexerError) {
++         await this.statusMapper.put(hash, height, Status.REINDEX)
++ } else {
++         await this.statusMapper.put(hash, height, Status.ERROR)
++ }

// cleanup
...
switch (status.status) {
           case Status.INVALIDATED:
           case Status.INDEXED:
++       case Status.REINDEX:        
        return
    }

it will solve the cleanup lock and reindex based on bestchain checker.. at the end.. we'd finally see the "issue" log

canonbrother · 2023-11-10T05:27:31Z

apps/whale-api/src/module.indexer/rpc.block.provider.ts

-      await this.invalidate(indexed.hash, indexed.height)
+      this.logger.log(`[Synchronize - not the best chain] Indexing prev block ${indexed.height}...`)
+      // Retry indexing the previous block before invalidating it
+      const MAX_RETRIES = 3


we do not need this ady after REINDEX..
all reindex/pre-index will be auto handling in synchronize
one retry pattern is sufficient

Updated, then we will not be reindexing the previous block, just the current block thats failing. Also fine with me, we just have to test on any stucked ocean, to see if fix still works the same :)
cc: @pierregee

canonbrother · 2023-11-10T05:28:09Z

apps/whale-api/src/module.indexer/rpc.block.provider.ts

@@ -100,7 +133,7 @@ export class RPCBlockProvider {
   * @param {defid.Block<Transaction>} nextBlock to check previous block hash
   */
  private static async isBestChain (indexed: Block, nextBlock: defid.Block<defid.Transaction>): Promise<boolean> {
-    return nextBlock.previousblockhash === indexed.hash
+    return indexed.hash === nextBlock.previousblockhash


nice 🤓 !! (lesser brain consuming)

apps/whale-api/src/module.indexer/rpc.block.provider.ts

canonbrother · 2023-11-10T06:02:37Z

i think need a log here tho...
https://github.com/BirthdayResearch/jellyfishsdk/blob/6f312b9b5a6c8c98e0c8418f55914a46b13f90c4/apps/whale-api/src/module.indexer/rpc.block.provider.ts#L92-L93
eg:

this.logger.error(`indexed{n: ${indexed.height}, h: ${indexed.hash}}, nextBlock{n: ${nextBlock.height}, prevH: ${nextBlock.previousblockhash}}`)

chore(whale-api): add a retry for missing previous block txns

da3a95f

github-actions bot added apps/whale-api area/apps kind/chore Non feature change labels Nov 7, 2023

set indexing to true if status mapper is set to error

a3b83c3

add a new REINDEX status

020c5ae

canonbrother reviewed Nov 10, 2023

View reviewed changes

apps/whale-api/src/module.indexer/rpc.block.provider.ts Outdated Show resolved Hide resolved

remove index retry for previous block

4528c67

add log inside not best chain case

3883065

pierregee marked this pull request as ready for review November 10, 2023 07:20

pierregee requested review from fuxingloh, ivan-zynesis, eli-lim, thedoublejay, kyleleow and pierregee as code owners November 10, 2023 07:20

lykalabrada changed the title ~~chore(whale-api): add a retry for missing previous block txns~~ chore(whale-api): add reindex for failed to indexed block Nov 10, 2023

canonbrother changed the title ~~chore(whale-api): add reindex for failed to indexed block~~ Bug(whale-api): add reindex for failed to indexed block Nov 10, 2023

github-actions bot removed the kind/chore Non feature change label Nov 10, 2023

canonbrother changed the title ~~Bug(whale-api): add reindex for failed to indexed block~~ bug(whale-api): add reindex for failed to indexed block Nov 10, 2023

canonbrother changed the title ~~bug(whale-api): add reindex for failed to indexed block~~ fix(whale-api): add reindex for failed to indexed block Nov 10, 2023

github-actions bot added the kind/fix Fix a bug label Nov 10, 2023

canonbrother mentioned this pull request Nov 10, 2023

fix(whale-api): Fix swap tx not found index #2170

Merged

canonbrother approved these changes Nov 10, 2023

View reviewed changes

fuxingloh merged commit dd01b74 into main Nov 10, 2023
37 of 38 checks passed

fuxingloh deleted the lyka/retry-prevblock-indexer branch November 10, 2023 07:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(whale-api): add reindex for failed to indexed block #2169

fix(whale-api): add reindex for failed to indexed block #2169

lykalabrada commented Nov 7, 2023 •

edited by canonbrother

Loading

netlify bot commented Nov 7, 2023 •

edited

Loading

codecov bot commented Nov 7, 2023 •

edited

Loading

github-actions bot commented Nov 7, 2023 •

edited

Loading

canonbrother commented Nov 10, 2023 •

edited

Loading

canonbrother Nov 10, 2023 •

edited

Loading

lykalabrada Nov 10, 2023

canonbrother Nov 10, 2023 •

edited

Loading

canonbrother commented Nov 10, 2023 •

edited

Loading

fix(whale-api): add reindex for failed to indexed block #2169

fix(whale-api): add reindex for failed to indexed block #2169

Conversation

lykalabrada commented Nov 7, 2023 • edited by canonbrother Loading

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Additional comments?:

netlify bot commented Nov 7, 2023 • edited Loading

✅ Deploy Preview for jellyfishsdk ready!

codecov bot commented Nov 7, 2023 • edited Loading

Codecov Report

github-actions bot commented Nov 7, 2023 • edited Loading

canonbrother commented Nov 10, 2023 • edited Loading

canonbrother Nov 10, 2023 • edited Loading

Choose a reason for hiding this comment

lykalabrada Nov 10, 2023

Choose a reason for hiding this comment

canonbrother Nov 10, 2023 • edited Loading

Choose a reason for hiding this comment

canonbrother commented Nov 10, 2023 • edited Loading

lykalabrada commented Nov 7, 2023 •

edited by canonbrother

Loading

netlify bot commented Nov 7, 2023 •

edited

Loading

codecov bot commented Nov 7, 2023 •

edited

Loading

github-actions bot commented Nov 7, 2023 •

edited

Loading

canonbrother commented Nov 10, 2023 •

edited

Loading

canonbrother Nov 10, 2023 •

edited

Loading

canonbrother Nov 10, 2023 •

edited

Loading

canonbrother commented Nov 10, 2023 •

edited

Loading