fix(whale-api): add reindex for failed to indexed block

apps/whale-api/src/module.indexer/rpc.block.provider.ts

@@ -6,6 +6,7 @@
 import { IndexStatusMapper, Status } from './status'
 import { waitForCondition } from '@defichain/testcontainers/dist/utils'
 import { blockchain as defid, RpcApiError } from '@defichain/jellyfish-api-core'
+import { NotFoundIndexerError } from './error'
 
 @Injectable()
 export class RPCBlockProvider {
@@ -44,6 +45,15 @@
       }
 
       try {
+        const status = await this.statusMapper.get()
+        this.logger.log(`[Start Indexing] - status: ${status?.status ?? ''}`)
+        if (status?.status === Status.REINDEX) {
+          const currentBlock = await this.client.blockchain.getBlock(status.hash, 2)
+          const prevBlock = await this.client.blockchain.getBlock(currentBlock.previousblockhash, 2)
+          this.logger.log(`Reindexing previous block ${prevBlock.height} ...`)
+          await this.statusMapper.put(prevBlock.hash, prevBlock.height, Status.INDEXING)
+        }
+
         await this.cleanup()
         this.indexing = await this.synchronize()
       } catch (err) {
@@ -88,9 +98,32 @@
 
     const nextBlock = await this.client.blockchain.getBlock(nextHash, 2)
     if (await RPCBlockProvider.isBestChain(indexed, nextBlock)) {
+      this.logger.log(`[Synchronize - best chain] Indexing next block ${nextBlock.height}...`)
       await this.index(nextBlock)
     } else {
-      await this.invalidate(indexed.hash, indexed.height)
+      this.logger.log(`[Synchronize - not the best chain] Indexing prev block ${indexed.height}...`)
+      // Retry indexing the previous block before invalidating it
+      const MAX_RETRIES = 3
+      let prevBlockIndexedSuccessfully = false
+      let prevBlockRetryCount = 0
+
+      while (!prevBlockIndexedSuccessfully && prevBlockRetryCount < MAX_RETRIES) {
+        try {
+          this.logger.log(`Retrying indexing block ${indexed.height} - Attempt ${prevBlockRetryCount + 1}`)
+          const previousBlock = await this.client.blockchain.getBlock(indexed.hash, 2)
+          await this.index(previousBlock)
+          prevBlockIndexedSuccessfully = true
+        } catch (error) {
+          this.logger.error(`Error indexing the previous block - ${indexed.height}`)
+          prevBlockRetryCount++
+        }
+      }
+
+      if (!prevBlockIndexedSuccessfully) {
+        // If all retries for indexing the previous block fail, invalidate it
+        await this.invalidate(indexed.hash, indexed.height)
+        this.logger.error('All retries for indexing the previous block have failed. The block has been invalidated.')
+      }
     }
     return true
   }
@@ -100,7 +133,7 @@
    * @param {defid.Block<Transaction>} nextBlock to check previous block hash
    */
   private static async isBestChain (indexed: Block, nextBlock: defid.Block<defid.Transaction>): Promise<boolean> {
-    return nextBlock.previousblockhash === indexed.hash
+    return indexed.hash === nextBlock.previousblockhash
   }
 
   public async indexGenesis (): Promise<boolean> {
@@ -121,6 +154,7 @@
     switch (status.status) {
       case Status.INVALIDATED:
       case Status.INDEXED:
+      case Status.REINDEX:
         return
     }
 
@@ -149,7 +183,11 @@
       await this.indexer.invalidate(hash)
       await this.statusMapper.put(hash, height, Status.INVALIDATED)
     } catch (err) {
-      await this.statusMapper.put(hash, height, Status.ERROR)
+      if (err instanceof NotFoundIndexerError) {
+        await this.statusMapper.put(hash, height, Status.REINDEX)
+      } else {
+        await this.statusMapper.put(hash, height, Status.ERROR)
+      }
       throw err
     }
   }

apps/whale-api/src/module.indexer/status.ts

@@ -36,7 +36,8 @@ export enum Status {
   INDEXED = 'INDEXED',
   INVALIDATING = 'INVALIDATING',
   INVALIDATED = 'INVALIDATED',
-  ERROR = 'ERROR'
+  ERROR = 'ERROR',
+  REINDEX = 'REINDEX'
 }
 
 export interface IndexStatus extends Model {