Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve client footer design #144

Closed

Conversation

jlmuir
Copy link
Contributor

@jlmuir jlmuir commented Sep 6, 2020

Before After
synchweb-footer-design-before synchweb-footer-design-after

@drnasmith
Copy link
Contributor

New structure for app layout is in the works. I will look to incorporate these changes in the new footer component.

@ndg63276
Copy link
Collaborator

ndg63276 commented Nov 1, 2023

Closing PR as it is very old. Branch will be deleted in 1 month unless someone objects.

@ndg63276 ndg63276 closed this Nov 1, 2023
@jlmuir
Copy link
Contributor Author

jlmuir commented Nov 1, 2023

I object, but I don't have much say. I still think the change is a good one. But if you reject the PR on behalf of the SynchWeb project, then OK, there's nothing else I can do. The age of the PR is irrelevant since it wasn't waiting on me, it was waiting on @drnasmith (see 2020-12-14 comment).

@ndg63276 ndg63276 reopened this Nov 1, 2023
@ndg63276
Copy link
Collaborator

ndg63276 commented Nov 1, 2023

I was asked to tidy up some old PRs, so I have closed a few, but happy to reopen. Neil has left and I have no idea what his new components were,

We would like to include a version number somewhere in the footer though, using the $synchweb_version parameter from the config.php file. So if you have thoughts on where that might go, do say so!

@jlmuir
Copy link
Contributor Author

jlmuir commented Nov 1, 2023

OK, thanks!

I don't see a benefit to displaying the version number, but if you want to, my suggestion would be to put it in parentheses to the right of "Powered by SynchWeb." For example:

Powered by SynchWeb (2023-R4.3)

I don't see many web apps displaying their version number, but one that does is Gerrit Code Review, which displays the following at the moment:

Powered by Gerrit Code Review (3.9.0-rc0-39-gbb6b2bf629) | Privacy | Terms

@ndg63276 ndg63276 changed the base branch from master to prerelease November 2, 2023 10:52
@ndg63276
Copy link
Collaborator

ndg63276 commented Nov 3, 2023

Cheers @jlmuir , I couldn't figure out how to add more to your PR, so I've made a new one at #692, with all your changes, plus the same changes for the Vue version of the site. I also added the Synchweb version after the 'Powered by Synchweb' link as suggested. Let me know if you have any thoughts!

Will close this one again as superseded.

@ndg63276 ndg63276 closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants