Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1053: Put synchweb version in footer #692

Merged

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Nov 3, 2023

JIRA ticket: LIMS_1053

Summary:

The MotD is not the best place for the Synchweb version number, so let's put it in the footer. While we're at it, let's improve the look of the footer, using @jlmuir's code from #144

Changes:

  • Move Synchweb link to left of footer, site link to the right
  • Do the same for both vue and non-vue versions
  • Expose $synchweb_version in the api/options endpoint
  • Add the Synchweb version to the footer if it is specified
  • Add the variable to the example config.php

To test:

  • View the footer on any page, check it looks ok
  • Check the $synchweb_version is displayed
  • Check no errors occur if $synchweb_version is absent

@ndg63276 ndg63276 merged commit 460783a into prerelease Nov 16, 2023
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1053/put-synchweb-version-in-footer branch November 16, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants