User-Defined Linear Map #743
Open
+1,125
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General structure. Co-authored-by: Chad Mitchell <[email protected]>
Update initialization of LinearMap element.
for more information, see https://pre-commit.ci
Finish implementation of LinearMap element push.
for more information, see https://pre-commit.ci
Initialize covariance matrix from distribution parameters.
for more information, see https://pre-commit.ci
…ance-and-transport-maps
Remove unnecessary ,.
cemitch99
changed the title
Correct naming in elements.cpp binding for LinearMap.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| } | ||
|
|
||
| //LinearTransport () = default; |
Check notice
Code scanning / CodeQL
Commented-out code Note
Correct argument declaration for Python bindings of LinearMap in elements.cpp.
Document "Name" parameter in LinearMap.
cemitch99
commented
Nov 5, 2024
cemitch99
commented
Nov 5, 2024
Modify zero-initialization of CovarianceMatrix cv.
This was referenced Jan 3, 2025
|
@cemitch99 please fetch branch again before continuing, I pushed a few updates for Python, docs and examples (they pass already :) ). |
ax3l
reviewed
Jan 6, 2025
5 tasks
Use parser for inputs. Needs upstream AMReX fix.
ax3l
reviewed
Jan 6, 2025
WeiqunZhang
pushed a commit
to AMReX-Codes/amrex
that referenced
this pull request
Jan 7, 2025
## Summary `ParmParse::queryAddWithParser` might manipulate the internal state and should not be a const method. These parser functions might need a unit test in AMReX? ## Additional background First seen in ECP-WarpX/impactx#743 ## Checklist The proposed changes: - [x] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
…ance-and-transport-maps-chad
ax3l
reviewed
Jan 10, 2025
Comment on lines
+6
to
+7
| This implements the same FODO cell as the :ref:`stable FODO cell example <examples-fodo>`. | ||
| However, in the example here we define *additional user-defined, custom linear elements* by providing a custom matrix. |
There was a problem hiding this comment.
TODO: In the analysis script of the FODO example, we should compare also values of the reference particle, in particular s and energy.
And reference particle pushing (drifting), if thick.
ax3l
force-pushed
the
topic-covariance-and-transport-maps
branch
from
0be1a9b to
317e6bf
Compare
cemitch99
commented
Jan 10, 2025
cemitch99
commented
Jan 10, 2025
for more information, see https://pre-commit.ci
Add twiss
Correct name of Rmat/R.
Fix naming of R again.
Fix number of periods.
ax3l
reviewed
Jan 12, 2025
ax3l
reviewed
Jan 12, 2025
| The matrix elements are 1-indexed. | ||
| The transport matrix :math:`R` is defaulted to the identity matrix, so only matrix entries that are differing from that need to be specified. | ||
|
|
||
| TODO: describe units to put in the R entries. |
ax3l
reviewed
Jan 12, 2025
| A custom, linear transport matrix. | ||
|
|
||
| TODO: describe units to put in the R entries. |
ax3l
reviewed
Jan 12, 2025
| @@ -82,7 +82,7 @@ function(add_impactx_test name input is_mpi analysis_script plot_script) | |||
| amrex.throw_exception = 1 | |||
| amrex.signal_handling = 0 | |||
| impactx.always_warn_immediately=1 | |||
| impactx.abort_on_warning_threshold=low | |||
| impactx.abort_on_warning_threshold=medium | |||
There was a problem hiding this comment.
Gotta check if we can keep it on low and only overwrite for the example.
Co-authored-by: Chad Mitchell <[email protected]>
ax3l
reviewed
Jan 12, 2025
| See the :ref:` example <examples-fodo-userdef>` for Python and inputs file syntax to specify a custom linear element. | ||
|
|
||
| The entries of the transport matrix are ordered for multiplication with the beam vector :math:`x,px,y,py,t,pt`. | ||
| The units of the transport matrix :math:`R` elements are... TODO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of the draft PR #714 owned by cemitch99. Close #538
amrex::SmallMatrixImpactX::evolve->ImpactX::track_particlesIntroducesim.track_particles()#741Follow-up PR will add
ImpactX::track_envelope