Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mosart1.1.08: Standardize time metadata #66

Merged
merged 12 commits into from
Jan 15, 2025

Conversation

samsrabin
Copy link
Contributor

@samsrabin samsrabin commented Jul 13, 2023

Description of changes

Standardizes a dimension name of output variable time_bounds, as well as attributes for that plus mcdate, mcsec, mdcur, and mscur.

Specific notes

Contributors other than yourself: @phillips-ad, @ekluzek

MOSART Issues Fixed:

Are answers expected to change (and if so in what way)? No.

Any User Interface Changes (namelist or namelist defaults changes)? No.

Testing performed

New metadata in a history file from a short test:

netcdf standardize-time-metadata.mosart.h0.1850-01-06-00000 {
dimensions:
	...
	nbnd = 2 ;
	...
variables:
	...
	int mcdate(time) ;
		...
		mcdate:calendar = "noleap" ;
	int mcsec(time) ;
		...
		mcsec:calendar = "noleap" ;
	int mdcur(time) ;
		...
		mdcur:calendar = "noleap" ;
	int mscur(time) ;
		...
		mscur:calendar = "noleap" ;
	...
	double time_bounds(time, nbnd) ;
		time_bounds:long_name = "time interval endpoints" ;
		time_bounds:units = "days since 1850-01-01 00:00:00" ;
		time_bounds:calendar = "noleap" ;

An arbitrarily-chosen CTSM test with MOSART, SMS_D_Ld3.f10_f10_mg37.I2000Clm50BgcCru.cheyenne_gnu.clm-default, passed bit-for-bit against tag ctsm5.1.dev130, despite the changed metadata.

  • Reminder to update ChangeLog

@mvertens
Copy link
Contributor

mvertens commented Jan 6, 2024

@slevis-lmwg @jedwards4b - I think this should be merged at this point. I can also bring these changes into #76 once it is merged.

@slevis-lmwg
Copy link
Contributor

@slevis-lmwg @jedwards4b - I think this should be merged at this point. I can also bring these changes into #76 once it is merged.

Thank you @mvertens.
The merge order that @ekluzek and I agreed to is here:
https://github.com/ESCOMP/CTSM/projects/6#column-4776614

…pass

Originally came in with mosart1.1.03.
May be reversed in another tag along the way, but I'm adding here to
proceed with successful testing in the series of "history" PRs.
Adding here separately to facilitate testing.
Fix for Nag compiler

Fix nag compiler, change ChangeLog to markdown format.
Remove complexity of having curr_date_in in timemgr_init
be optional and make it required. As was done in RTM.
@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Jan 15, 2025

I will initiate testing, update the ChangeLog, and make a new tag.
derecho OK ./run_sys_tests -s mosart -c mosart1.1.06-ctsm5.3.019 -g mosart1.1.08-ctsm5.3.019
izumi PASS ./run_sys_tests -s mosart -c mosart1.1.06-ctsm5.3.019 -g mosart1.1.08-ctsm5.3.019

@slevis-lmwg slevis-lmwg merged commit 00a87c9 into ESCOMP:master Jan 15, 2025
@slevis-lmwg slevis-lmwg changed the title Standardize time metadata mosart1.1.08: Standardize time metadata Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Modify naming and attributes of time variables on history files to be consistent with other CESM components
4 participants