-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.20.1] Add mappings for AbstractNbtList.add/remove #3837
base: 1.20.1
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, the mapping change looks reasonable. I would sort the toolchain stuff out as a diffrent thing.
I see this is for 1.20.1 which is fine, just want to double check that these have been named in the main branch?
We usually don't add mappings to older versions of the game... |
More importantly, I don't think it's necessary (or desirable) to map these synthetic bridge methods. |
Well as meaningless as it may seem, I do need them to be mapped, in order to extend the class, all so to provide a mirror instance of another, albeit with some form of "listeners", in order to make each changes be reflected on another object within the mod I am currently working on.
Honestly I do not know enough of dealing with mappings to know really what should or shouldn't be done, I am only trying to do what feels the most logical. Also, additional point, the original mapping was only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lowkey wondering what's the hold-up here
Sorry, this needs manually testing IMO to make sure its the correct change. As its for an older minecraft version its lower on the priority list, not helped by the fact I have been busy with 1.20.5 stuff and my laptop broke. Sorry again, ill try and get to this soon. |
I think the existence of these mappings are solely for naming the parameters; these synthetic bridge methods should have their names auto-populated by our tools (enigma, stitch/loom) already. I recall enigma has some problem with populating names while stitch/loom works totally fine. |
Fixes NBT lists
add
andremove
methods getting mixed up with their synthetic obfuscation.Ensures Gradle to pick JVM 17 when the local default is set to another version (prevents Enigma from running properly)