Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.1] Add mappings for AbstractNbtList.add/remove #3837

Open
wants to merge 4 commits into
base: 1.20.1
Choose a base branch
from
Open

[1.20.1] Add mappings for AbstractNbtList.add/remove #3837

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
53f71fd
enforce using Java 17 when default jvm is another one
NerjalNosk Apr 6, 2024
62566f9
Fix AbstractNbtList add/remove mapping
NerjalNosk Apr 6, 2024
bdec53b
revert non-working Jdk fix attempt
NerjalNosk Apr 6, 2024
9a47f1f
Change remapping to properly rename synthetic obfuscation methods
NerjalNosk Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,9 @@ combineUnpickDefinitions {
java {
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
toolchain {
languageVersion.set(JavaLanguageVersion.of(17))
}
NerjalNosk marked this conversation as resolved.
Show resolved Hide resolved
}

tasks.withType(JavaCompile).configureEach {
Expand Down
4 changes: 2 additions & 2 deletions mappings/net/minecraft/nbt/AbstractNbtList.mapping
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
CLASS net/minecraft/class_2483 net/minecraft/nbt/AbstractNbtList
COMMENT Represents an abstraction of a mutable NBT list which holds elements of the same type.
METHOD add (ILjava/lang/Object;)V
METHOD add add (ILjava/lang/Object;)V
NerjalNosk marked this conversation as resolved.
Show resolved Hide resolved
ARG 1 index
ARG 2 value
METHOD method_10533 addElement (ILnet/minecraft/class_2520;)Z
Expand All @@ -21,7 +21,7 @@ CLASS net/minecraft/class_2483 net/minecraft/nbt/AbstractNbtList
COMMENT Gets the {@linkplain NbtElement#getType type} of element that this list holds.
COMMENT
COMMENT @return the type of element that this list holds
METHOD remove (I)Ljava/lang/Object;
METHOD remove remove (I)Ljava/lang/Object;
ARG 1 index
METHOD set (ILjava/lang/Object;)Ljava/lang/Object;
ARG 1 index
Expand Down
Loading