-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SFR-Mstars plane python script #21
base: devel
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR adds a new Python script that generates plots showing the relationship between Star Formation Rate (SFR) and stellar mass at different redshifts (z=0,1,2). The script creates a panel of three plots, each representing a different redshift, and includes observational data and theoretical fits for comparison. The implementation uses matplotlib for visualization and includes statistical utilities for data processing. Class diagram for the SFR-Mstars plane scriptclassDiagram
class SFRMstarsPanel {
+observation
+logger
+GyrToYr
+Zsun
+XH
+MpcToKpc
+mlow
+mupp
+dm
+mbins
+xmf
+imf
+mlow2
+mupp2
+dm2
+mbins2
+xmf2
+mlow3
+mupp3
+dm3
+mbins3
+xmf3
+ssfrlow
+ssfrupp
+dssfr
+ssfrbins
+xssfr
+sfrlow
+sfrupp
+dsfr
+sfrbins
+xsfr
+size1
+size2
+stext
+fsize
+saxis
+linw1
+linw2
+linw3
+linw4
+spad
+spadx
+spady
+col
+logMstars
+sfms_fit_popesso23(t)
+sfms_fit_schreiber15(m, z)
+plot_sfms(plt, outdir, h0, omega_m, omega_b, obsdir, mainseqsf_1)
+prepare_data(hdf5_data, index, mainseqsf)
+main(modeldir, outdir, redshift_table, subvols, obsdir)
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @angel-chandro - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider moving the plotting constants (sizes, line widths, colors, etc.) to a configuration file to improve maintainability and make the visualization parameters more easily adjustable.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Python script that generates the SFR vs stellar mass plane at z=0,1,2 with some additional observational data.
Summary by Sourcery
New Features: