kh/fix/make file settings configurable #71
Conversation
bromiesTM
force-pushed
the
kh/fix/make-file-settings-configurable
branch
3 times, most recently
from
54f3174 to
8605780
Compare
printminion-co
force-pushed
the
kh/fix/make-file-settings-configurable
branch
from
8605780 to
b49d9dc
Compare
There was a problem hiding this comment.
review done in #75
- found logical error
- extended tests
- fixed formatting
bromiesTM
force-pushed
the
kh/fix/make-file-settings-configurable
branch
from
b49d9dc to
c904156
Compare
bromiesTM
force-pushed
the
kh/fix/make-file-settings-configurable
branch
from
c904156 to
fbd9975
Compare
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Not ok: in_array("foo", [true, false]); // returns true
ok: in_array("foo", [true, false], true); // returns false
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
bromiesTM
force-pushed
the
kh/fix/make-file-settings-configurable
branch
from
fbd9975 to
07e1a8b
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
No description provided.