Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mk/review/kh/fix/make file settings configurable #75

Conversation

printminion-co
Copy link

Summary

TODO

  • ...

Checklist

printminion-co and others added 8 commits December 12, 2024 14:43
Not ok: in_array("foo", [true, false]); // returns true
ok: in_array("foo", [true, false], true); // returns false

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
spaces vs tabs

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
add exception test

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
remove tests since it added earlier

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
extend test with 3-rd required attribute

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
fix function logic
add more extensive test

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
@bromiesTM bromiesTM force-pushed the kh/fix/make-file-settings-configurable branch 3 times, most recently from fbd9975 to 07e1a8b Compare December 13, 2024 11:59
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@printminion-co printminion-co deleted the mk/review/kh/fix/make-file-settings-configurable branch January 7, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants