chore(ci) ignore unused lcov exclusions #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
=============================================
Coverage 90.82650% 90.82650%
=============================================
Files 53 53
Lines 11337 11337
Branches 1597 1692 +95
=============================================
Hits 10297 10297
Misses 1034 1034
Partials 6 6 see 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
thibaultcha
force-pushed
the
chore/ci-lcov-ignore
branch
9 times, most recently
from
63155a8 to
f8f16da
Compare
* Ignore unused lcov exclusions: in our non-debug builds the `src/common/debug` exclude is unused and latest lcov complains about it. * Ignore geninfo source errors: these are very tricky to get right considering the openresty bundle archive file structure makes for an inconvenient `--base-directory` argument.
The new `ubuntu-latest` image (24.04) would cause OpenResty 1.21.4.1 to not find the Perl lib during compilation. OpenResty 1.27.1.1 can find the lib without problems.
thibaultcha
force-pushed
the
chore/ci-lcov-ignore
branch
from
f8f16da to
6a28643
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our non-debug builds the
src/common/debugexclude is unused and latest lcov complains about it.