Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci) ignore unused lcov exclusions #660

Merged
merged 2 commits into from
Jan 14, 2025
Merged

chore(ci) ignore unused lcov exclusions #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa44dd4
chore(ci) minor lcov fixes
thibaultcha Jan 14, 2025
6a28643
tests(build) fix failing tests on ubuntu 24.04
thibaultcha Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/job-unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,13 +151,13 @@ jobs:
run: |
case "$CC" in
clang*)
lcov --gcov-tool gcov --capture --directory work/buildroot --base-directory work/nginx-patched --output-file lcov.info
lcov --gcov-tool gcov --remove lcov.info "*/ngx_wasm_module/src/common/debug/*" --output-file lcov.info
lcov --gcov-tool gcov --ignore-errors source --capture --directory work/buildroot --output-file lcov.info
lcov --ignore-errors unused --gcov-tool gcov --remove lcov.info "*/ngx_wasm_module/src/common/debug/*" --output-file lcov.info
lcov --gcov-tool gcov --extract lcov.info "*/ngx_wasm_module/src/*" --output-file lcov.info
;;
*)
lcov --gcov-tool gcov-${CC#*-} --capture --directory work/buildroot --output-file lcov.info
lcov --gcov-tool gcov-${CC#*-} --remove lcov.info "*/ngx_wasm_module/src/common/debug/*" --output-file lcov.info
lcov --gcov-tool gcov-${CC#*-} --ignore-errors source --capture --directory work/buildroot --output-file lcov.info
lcov --ignore-errors unused --gcov-tool gcov-${CC#*-} --remove lcov.info "*/ngx_wasm_module/src/common/debug/*" --output-file lcov.info
lcov --gcov-tool gcov-${CC#*-} --extract lcov.info "*/ngx_wasm_module/src/*" --output-file lcov.info
;;
esac
Expand Down
21 changes: 16 additions & 5 deletions t/10-build/001-build_options.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,16 +136,27 @@ ngx_stream_wasm_module


=== TEST 10: build with OpenResty
--- build: NGX_BUILD_OPENRESTY=1.21.4.1 make
--- build: NGX_BUILD_OPENRESTY=1.27.1.1 make
--- grep_nginxV
openresty/1.21.4.1 (ngx_wasmx_module dev [debug
openresty/1.27.1.1 (ngx_wasmx_module dev [debug
built with OpenSSL
--with-debug
-O0 -ggdb3 -gdwarf



=== TEST 11: build without IPC by default
=== TEST 11: build with OpenResty without debug
--- build: NGX_BUILD_OPENRESTY=1.27.1.1 NGX_BUILD_DEBUG=0 NGX_BUILD_CC_OPT= make
--- grep_nginxV
openresty/1.27.1.1 (ngx_wasmx_module dev
built with OpenSSL
--- no_grep_nginxV
--with-debug
-O0 -ggdb3 -gdwarf



=== TEST 12: build without IPC by default
--- build: make
--- grep_nginxV
ngx_wasmx_module dev [debug
Expand All @@ -158,7 +169,7 @@ ngx_ipc_core_module



=== TEST 12: build with IPC (NGX_IPC=1)
=== TEST 13: build with IPC (NGX_IPC=1)
--- build: make NGX_IPC=1
--- grep_nginxV
ngx_wasmx_module dev [ipc
Expand All @@ -170,7 +181,7 @@ ngx_ipc_core_module



=== TEST 13: build with IPC (NGX_IPC=YES)
=== TEST 14: build with IPC (NGX_IPC=YES)
--- build: make NGX_IPC=YES
--- grep_nginxV
ngx_wasmx_module dev [ipc
Expand Down
Loading