Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create shareable stylelint package for lucca-front. #2745

Draft
wants to merge 41 commits into
base: rc
Choose a base branch
from

Conversation

fbasmaison-lucca
Copy link
Contributor

@fbasmaison-lucca fbasmaison-lucca commented Apr 19, 2024

Description

Add a shareable stylelint config package for Lucca Front.


  • It extends sensible rules provided by existing configurations.
  • It lists deprecated variables and classes used in SCSS files.
  • A documentation on how to install, configure and use is provided.
  • It is based on its implementation in Cleemy, and a previous workshop on the subject.

Commits address rules with errors individually, either by ignoring them for now, or fixing them.


LF features are marked as warnings or errors in a terminal

@fbasmaison-lucca fbasmaison-lucca added 🔖✨ Feature New feature (even a very small one) 🔨 Technical Doesn't affect the output (refactor, dependencies update, cleaning, etc.) labels Apr 19, 2024
@LuccaIntegration
Copy link

@CCNET-iLucca
Copy link

Tests d'interfaces

@LuccaIntegration
Copy link

@CCNET-iLucca
Copy link

Tests d'interfaces

@jeremie-lucca jeremie-lucca added this to the 17.5 milestone Apr 30, 2024
@jeremie-lucca jeremie-lucca mentioned this pull request May 31, 2024
@jeremie-lucca jeremie-lucca modified the milestones: 18.1, 18.2 Jun 18, 2024
@jeremie-lucca jeremie-lucca modified the milestones: 18.2, 18.3 Aug 20, 2024
@jeremie-lucca jeremie-lucca modified the milestones: 18.3, 18.4 Oct 24, 2024
@jeremie-lucca jeremie-lucca removed this from the 19.1 milestone Dec 9, 2024
@c-3po c-3po bot added the 📖 Documentation changes Requires a Prisme update label Jan 13, 2025
@LuccaIntegration
Copy link

1 similar comment
@LuccaIntegration
Copy link

@LuccaIntegration
Copy link

4 similar comments
@LuccaIntegration
Copy link

@LuccaIntegration
Copy link

@LuccaIntegration
Copy link

@LuccaIntegration
Copy link

@LuccaIntegration
Copy link

1 similar comment
@LuccaIntegration
Copy link

@fbasmaison-lucca
Copy link
Contributor Author

@jeremie-lucca : J’ai intégré les changements dont je t’ai parlé dans cette PR.

On constate qu’il restait un --spacings-S, entre autres choses. :)

Cette Issue a plus de détails, notamment sur ce que j’imagine côté front. (cc @Supamiu)

Reparlons-en quand vous pourrez. :)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
… and allow having lines between @ rules with the same name, so that config files don’t become a pain.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
… and allow not to have lines between variables, so that config files don’t become a pain.
… and allow some files to be empty (angular and scss components).
@LuccaIntegration
Copy link

1 similar comment
@LuccaIntegration
Copy link

Comment on lines +22 to +31
// 'block-no-empty': null,
// 'font-family-no-missing-generic-family-keyword': null,
// 'no-descending-specificity': null,
// 'no-duplicate-selectors': null,
// 'property-no-vendor-prefix': null,
// 'scss/at-mixin-argumentless-call-parentheses': null,
// 'scss/at-mixin-pattern': null,
// 'scss/at-rule-conditional-no-parentheses': null,
// 'scss/at-rule-no-unknown': null,
// 'selector-not-notation': null,
Copy link
Contributor Author

@fbasmaison-lucca fbasmaison-lucca Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The broken PR is on purpose, so that we can have a look at it together.

I commented these lines to enable default config rules for CSS and SCSS configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Documentation changes Requires a Prisme update 🔖✨ Feature New feature (even a very small one) 🔨 Technical Doesn't affect the output (refactor, dependencies update, cleaning, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants