Fix ABC usage issues #317
Merged
Fix ABC usage issues #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Inherit from ABC if there @abstractmethods 2. Do not make gen_srun_success_check() abstruct, simply return an empty string by default. When needed, this method will be overriden.
amaslenn
requested review from
TaekyungHeo,
srivatsankrishnan and
srinivas212
TaekyungHeo
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
ruffandpyrightdo not catch such issues. Here is pyright's position about it: @abstractmethod should only be allowed on classes derived from ABCMeta microsoft/pyright#3952Additional Notes
—