Fix ABC usage issues

src/cloudai/_core/command_gen_strategy.py

@@ -14,13 +14,13 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from abc import abstractmethod
+from abc import ABC, abstractmethod
 
 from .test_scenario import TestRun
 from .test_template_strategy import TestTemplateStrategy
 
 
-class CommandGenStrategy(TestTemplateStrategy):
+class CommandGenStrategy(TestTemplateStrategy, ABC):
     """
     Abstract base class defining the interface for command generation strategies across different system environments.
 
@@ -53,7 +53,6 @@ def gen_srun_command(self, tr: TestRun) -> str:
         """
         pass
 
-    @abstractmethod
     def gen_srun_success_check(self, tr: TestRun) -> str:
         """
         Generate the Slurm success check command to verify if a test run was successful.
@@ -64,4 +63,4 @@ def gen_srun_success_check(self, tr: TestRun) -> str:
         Returns:
             str: The generated command to check the success of the test run.
         """
-        pass
+        return ""

src/cloudai/_core/json_gen_strategy.py

@@ -15,14 +15,14 @@
 # limitations under the License.
 
 import re
-from abc import abstractmethod
+from abc import ABC, abstractmethod
 from typing import Any, Dict
 
 from .test_scenario import TestRun
 from .test_template_strategy import TestTemplateStrategy
 
 
-class JsonGenStrategy(TestTemplateStrategy):
+class JsonGenStrategy(TestTemplateStrategy, ABC):
     """
     Abstract base class for generating Kubernetes job specifications based on system and test parameters.
 

src/cloudai/_core/test.py

@@ -90,7 +90,7 @@ class CmdArgs(BaseModel):
     model_config = ConfigDict(extra="forbid")
 
 
-class TestDefinition(BaseModel):
+class TestDefinition(BaseModel, ABC):
     """Base Test object."""
 
     __test__ = False