rubyPackages.pg: use pkg-config instead of pg_config #237858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change forces pg native extension to use pkg-config to locate libpq
instead of running pg_config. It also removes an unnecessary reference
to postgresql package since build flags are embedded in the output at
`$out/${ruby.gemPath}/build_info/*`.
|
Result of 15 packages built:
|
|
Result of 15 packages built:
|
kirillrdy
reviewed
Jun 15, 2023
| # Note that setting --with-pg-config=${postgresql}/bin/pg_config would add | ||
| # an unnecessary reference to the entire postgresql package. | ||
| buildFlags = [ "--with-pg-config=ignore" ]; | ||
| nativeBuildInputs = [ pkg-config ]; |
There was a problem hiding this comment.
just for reference, #234470 once that gets merged we can just switch to use libpq instead of postgresql
There was a problem hiding this comment.
Thanks, subscribed to PR updates.
|
Result of 4 packages marked as broken and skipped:
15 packages built:
@tie just checking did you ommit broken/skipped packages ? |
kirillrdy
approved these changes
Jun 15, 2023
|
@kirillrdy, I’ve run Thanks for pointing that out though, I’ve re-read |
|
Result of 4 packages marked as broken and skipped:
15 packages built:
|
|
Result of 2 packages marked as broken and skipped:
10 packages built:
|
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change forces pg native extension to use pkg-config to locate libpq instead of running pg_config. It also removes an unnecessary reference to postgresql package since build flags are embedded in the output at
$out/${ruby.gemPath}/build_info/*.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)