Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-23.05] rubyPackages.pg: use pkg-config instead of pg_config #238442

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Bot-based backport to release-23.05, triggered by a label in #237858.

  • Before merging, ensure that this backport complies with the Criteria for Backporting.
    • Even as a non-commiter, if you find that it does not comply, leave a comment.

This change forces pg native extension to use pkg-config to locate libpq
instead of running pg_config. It also removes an unnecessary reference
to postgresql package since build flags are embedded in the output at
`$out/${ruby.gemPath}/build_info/*`.

(cherry picked from commit 1a54459)
@NickCao
Copy link
Member

NickCao commented Jun 19, 2023

Result of nixpkgs-review pr 238442 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • discourse
  • discourseAllPlugins
  • rubyPackages_2_7.pg
  • rubyPackages_2_7.sequel_pg
15 packages built:
  • gitlab
  • gitlab-ee
  • ledger-web
  • mastodon
  • metasploit
  • msfpc
  • pgsync
  • redmine
  • rubyPackages.pg (rubyPackages_3_1.pg)
  • rubyPackages.sequel_pg (rubyPackages_3_1.sequel_pg)
  • rubyPackages_3_0.pg
  • rubyPackages_3_0.sequel_pg
  • rubyPackages_3_2.pg
  • rubyPackages_3_2.sequel_pg
  • social-engineer-toolkit

@NickCao NickCao merged commit c081dc2 into release-23.05 Jun 19, 2023
@emilylange emilylange deleted the backport-237858-to-release-23.05 branch June 23, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants