Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] agreement #628

Merged
merged 23 commits into from
Feb 15, 2021
Merged

[13.0][MIG] agreement #628

merged 23 commits into from
Feb 15, 2021

Conversation

sergio-teruel
Copy link
Contributor

@sergio-teruel sergio-teruel commented Feb 14, 2021

cc @Tecnativa TT27165
ping @carlosdauden @CarlosRoca13
Superseeds PR #578 without name changed.

@sergio-teruel
Copy link
Contributor Author

Runbot display fail but is runing... why??

@pedrobaeza
Copy link
Member

See the video to know how to get to the problem:

Peek.14-02-2021.21-54.mp4

@pedrobaeza pedrobaeza added this to the 13.0 milestone Feb 15, 2021
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the migration commit contains black/prettier formatting. Can you please isolate that one so it's not contaminated with it and the review is done more accurately?

<field name="model_id" ref="model_agreement" />
<field
name="domain_force"
>['|', ('company_id', '=', False), ('company_id', 'child_of', [user.company_id.id])]</field>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule must be transformed and migration scripts should be added. See in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0 the line about that.

ygol and others added 22 commits February 15, 2021 20:56
we move the is_template field definition and the agreement.type model from
the agreement_legal module to the agreement module.

The fields are not displayed by default, unless the feature is enabled through a
technical feature group, this is configurable in the agreement_sale module (because agreement
in itself has no UI, and agreement_legal enables the feature by default)
- The `agreement` model now features mail and activities from its base module.
- The `agreement_legal` module doesn't need to add mail support now.
- Add activities to form views.

@Tecnativa TT22477
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-12.0/contract-12.0-agreement
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement/
Update agreement and agreement_sale to restore the behavior of v10
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-628-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 55ad664 into OCA:13.0 Feb 15, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c3cdae1. Thanks a lot for contributing to OCA. ❤️

olgamarcocb pushed a commit to tegin/contract that referenced this pull request Nov 16, 2021
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.