[OHI-1547] fix(docker): run compression regardless of APP_CONFIG being present ( in cases such as volume mount) #4673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-platform-docs canceled.
|
✅ Deploy Preview for ohif-dev canceled.
|
Viewers
|
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
fix/docker
|
| Run status |
|
| Run duration | 02m 08s |
| Commit |
|
| Committer | Ibrahim |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
44
|
| View all changes introduced in this branch ↗︎ | |
IbrahimCSAE
commented
Jan 10, 2025
| echo "Not using custom app config" | ||
|
|
||
| if [ -f /usr/share/nginx/html${PUBLIC_URL}app-config.js ]; then | ||
| if [ -s /usr/share/nginx/html${PUBLIC_URL}app-config.js ]; then |
There was a problem hiding this comment.
check if empty
IbrahimCSAE
commented
Jan 10, 2025
| then | ||
| echo "Not using custom app config" | ||
|
|
||
| if [ -f /usr/share/nginx/html${PUBLIC_URL}app-config.js ]; then |
There was a problem hiding this comment.
check if exists
IbrahimCSAE
changed the title
|
Thank you for fixing that. |
Yes, let me do that, thanks Bill |
|
I merged too quick sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Docker compression step was not being triggered if APP_CONFIG is not present, but it should still do if a user mounts a file using volumes.
Fixes OHIF-1547
Closes #4669