Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support base custom application installation location #729

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: support base custom application installation location #729

wants to merge 1 commit into from

Conversation

myml
Copy link
Collaborator

@myml myml commented Sep 29, 2024

base可以通过app_home信息设置应用安装位置 如果base设置了app_home,
玲珑在构建时会将PREFIX设置成app_home指定的目录
在运行时也会将应用文件挂载成app_home指定的目录

@myml myml changed the title feat: Support base custom application installation location feat: support base custom application installation location Sep 29, 2024
@myml myml mentioned this pull request Sep 29, 2024
Draft
@myml myml closed this Sep 29, 2024
@myml myml reopened this Sep 29, 2024
black-desk
black-desk requested changes Oct 9, 2024
View reviewed changes
api/schema/v1.json Outdated Show resolved Hide resolved
api/schema/v1.yaml Outdated Show resolved Hide resolved
api/schema/v1.yaml Outdated Show resolved Hide resolved
api/schema/v1.yaml Outdated Show resolved Hide resolved
apps/generators/05-initialize/src/main.cpp Outdated Show resolved Hide resolved
apps/generators/25-host-env/src/main.cpp Outdated Show resolved Hide resolved
libs/linglong/src/linglong/builder/linglong_builder.cpp Outdated Show resolved Hide resolved
@myml myml force-pushed the apphome branch 2 times, most recently from f3ad675 to 601e0bc Compare October 9, 2024 06:30
@myml myml requested a review from black-desk October 9, 2024 06:32
@black-desk
Copy link
Collaborator

@myml 来rebase一下 我有点没太看懂。

@myml myml closed this Nov 21, 2024
@myml
feat: support base custom application installation location
1eecbe3 
base可以通过app_prefix信息设置应用安装位置 如果base设置了app_prefix,
玲珑在构建时会将PREFIX设置成app_prefix指定的目录
在运行时也会将应用文件挂载成app_prefix指定的目录
@myml myml reopened this Nov 21, 2024
@deepin-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myml
Once this PR has been reviewed and has the lgtm label, please assign black-desk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@deepin-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myml
Once this PR has been reviewed and has the lgtm label, please assign black-desk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-desk black-desk Awaiting requested review from black-desk

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myml @black-desk @deepin-ci-robot