Fix: 500 error on Dataset validation

[Geeker1]

Description

During dataset upload, an Attribute error is thrown if profile is None, fixed this by writing the clean method for that field, raising a Validation error if profile is None.

Related Issue

#204

How to test it locally

Changelog

Added

Updated

Removed

Checklist

• 🚀 is the code ready to be merged and go live?
• 🛠 does it work (build) locally

Pull Request

• 📰 good title
• 📝good description
• 🔖 issue linked
• 📖 changelog filled out

Commits

• commits are clean
• commit messages are clean

Code Quality

• 🚧 no commented out code
• 🖨 no unnecessary logging
• 🎱 no magic numbers
• black was run locally (as part of the pre-commit hook)

Testing

• ✅ added (appropriate) unit tests
• 💢 edge cases in tests were considered
• ✅ ran tests locally & are passing

[milafrerichs]

this not the intended solution.

the profile is not mandatory. but the profile is mandatory when the permission type is private. so we need a check here but only if the permission is private.

What we need to do is to check the code here:

https://github.com/OpenUpSA/wazimap-ng/blob/staging/wazimap_ng/datasets/admin/dataset_admin.py#L113-L114

And only run that if the profile is set.

[milafrerichs]

I would merge those together and make it more obvious
if permission_type == 'private' and profile == None