Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Traditional Chinese README.md. #84

Merged
merged 10 commits into from
Nov 16, 2024
Merged

Conversation

RejectVanity
Copy link
Contributor

@RejectVanity RejectVanity commented Nov 15, 2024

Changes

Create a Traditional Chinese README, specify the file name for the Simplified Chinese README, and store both in the "READMEs" directory.

(Standardize the filename of the Simplified Chinese README according to the IETF language tag standard.)

Why

Write here why you think this should be merged

Checkmarks

  • The modified functions have been tested.
  • Used the same indentation as the rest of the project.
  • Updated documentation (changelog).

Additional information

I accidentally closed pull request #81 recently. Now, I have created a new pull request (#84) and also synchronized the latest changes from #80 into it.

Create a Traditional Chinese version of README.md and place it in the 'READMEs' directory.

Signed-off-by: 何意挽秋風 <[email protected]>
Standardize the filename of the Simplified Chinese README according to the IETF language tag standard.

Signed-off-by: 何意挽秋風 <[email protected]>
Update the links to the Simplified Chinese and Traditional Chinese README in the README.md.

Signed-off-by: 何意挽秋風 <[email protected]>
Signed-off-by: 何意挽秋風 <[email protected]>
Signed-off-by: 何意挽秋風 <[email protected]>
@ThePedroo ThePedroo added confirmed This issue or pull request is confirmed to be done. enhancement New feature or request labels Nov 15, 2024
Copy link
Member

@ThePedroo ThePedroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ThePedroo ThePedroo self-requested a review November 15, 2024 20:19
Copy link
Member

@ThePedroo ThePedroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I missed something. Feel free to fix those in the Simplified Chinese too.

READMEs/README_zh-TW.md Outdated Show resolved Hide resolved
READMEs/README_zh-TW.md Outdated Show resolved Hide resolved
READMEs/README_zh-TW.md Outdated Show resolved Hide resolved
READMEs/README_zh-TW.md Outdated Show resolved Hide resolved
Trying to align the "|", but it seems impossible to fully align when there is a mix of Chinese and English text.

Based on this, I can only optimize the layout as much as possible.

Signed-off-by: 何意挽秋風 <[email protected]>
Trying to align the "|", but it seems impossible to fully align when there is a mix of Chinese and English text.

Based on this, I can only optimize the layout as much as possible.

Signed-off-by: 何意挽秋風 <[email protected]>
Copy link
Collaborator

@RainyXeon RainyXeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk if it's possible to be aligned or not.
But imo, I prefer the | to be aligned in README_zh-TW

Let me know it's not possible


| 依賴 | 說明 |
|-----------|----------------------------------------------|
| `lsplt` | Android 的簡單 PLT(程式連結表) 勾取 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just remove one space here? Then it will be the best that can be done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just remove one space here? Then it will be the best that can be done.

Hope I didn't misunderstand your original intention.😊


| 依賴 | 說明 |
|----------|----------------------------------------------|
| `lsplt` | Android 的簡單 PLT(程式連結表) 勾取 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `lsplt` | Android 的簡單 PLT(程式連結表) 勾取 |
| `lsplt` | Android 的簡單 PLT(程式連結表) 勾取 |

Oh, I mean this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the last commit if possible: git reset --soft HEAD~1 and unstage the changes (the command to do so shows in git status)

@ThePedroo ThePedroo merged commit 5d9276e into PerformanC:main Nov 16, 2024
1 check passed
@ThePedroo
Copy link
Member

Thank you!

JingMatrix pushed a commit to JingMatrix/ReZygisk that referenced this pull request Dec 12, 2024
This commit adds Traditional Chinese translation for README.

Signed-off-by: 何意挽秋風 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed This issue or pull request is confirmed to be done. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants