The Great Ocean Revamp #967
Conversation
There was a problem hiding this comment.
The climate parameters don't appear well thought out.
The base ocean is antiMountain, the shallow ocean is flatland and the cliffs are mountain
Based on how the climate generator tries to separate these three tags, we end up always seeing cliffs next to shallow ocean. This seems unintentional.
Also why did you remove the islands?
| .minHeight = -1, | ||
| .maxHeight = 5, | ||
| .chance = 0.25, | ||
| .mountains = 50, |
There was a problem hiding this comment.
The cliffs that stick out of the water do appear rather flat/round. Maybe more mountain noise would be good?
|
Yeah, whoops ^_^ |
Do you have an example of this, because I don't think it really works without subbiomes. |
|
|
Should I convert the ocean cliffs to a sub-biome? |
|
Right, made a push. I tried to salvage the ideas of cliffs, being sort of like those things pirates would fear. "Arrrg, avoid the Cliffs o' Doom." I also re-added shelves. There's still work to be done, I just need your opinion. |
| .depth = 2, | ||
| .smoothness = 0.2, | ||
| }, | ||
| }, | ||
| .transitionBiomes = .{ | ||
| .{ | ||
| .id = "cubyz:beach", | ||
| .id = "cubyz:ocean/cliffs", | ||
| .chance = 0.25, |
There was a problem hiding this comment.
The new cliffs look nice, but I think you should make it rarer, the oceans appear to be cluttered with cliffs now.
| .id = "cubyz:ocean/cliffs", | ||
| .chance = 0.25, | ||
| .width = 2, | ||
| .properties = .{.antiMountain, .ocean}, |
There was a problem hiding this comment.
ocean is redundant, since the parent biome is already an ocean anyways.
| }, | ||
| .radius = 500, | ||
| .minHeight = -4, | ||
| .minHeight = -2, | ||
| .maxHeight = 0, |
There was a problem hiding this comment.
Maybe also set maxHeight to -2 for a more consistent transition?
| .chance = 1, | ||
| .keepOriginalTerrain = 0.1, |
There was a problem hiding this comment.
I think this might break the transition in some cases. But you should test it out if that really is the cause.
|
|
||
| .radius = 128, | ||
| .minHeight = -64, | ||
| .maxHeight = -32, |
There was a problem hiding this comment.
The shallow biome is kind of difficult to see in the rest of the ocean, maybe it should be shallower?
Oceans now dominate the sea!
Edit: .... yeah duh