Kit editing #31

Lagggpixel · 2023-08-13T14:37:23Z

No description provided.

Lagggpixel · 2023-08-13T14:43:03Z

Thanks sonarcloud for the approval.

...ox Classic/src/main/java/plugily/projects/minigamesbox/classic/utils/helper/ArmorHelper.java

montlikadani · 2023-08-13T14:57:05Z

...sic/src/main/java/plugily/projects/minigamesbox/classic/utils/configuration/ConfigUtils.java

+   * @return       Return value is true if the data value was not set and has now been set.
+   */
+  public static boolean setIfAbsent(FileConfiguration config, String key, Object data) {
+    if (!config.isSet(key) || !config.contains(key) || config.get(key) == null) {


These 3 condition literally doing the same check.

Redundancy in case one of them breaks for some random reason.

I doubt it, using the get method is completely sufficient. If you want a deep check, you can use the isSet method as this checks to copy the default value or not.

why we got this if its never used?

oh, I didn't even see it isn't used

MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/basekits/Kit.java

MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/KitRegistry.java

This reverts commit 90b140d.

#31 (comment)

montlikadani · 2023-08-15T07:35:48Z

MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/basekits/Kit.java

+      for (Integer slot : slots) {
+        switch (slot) {
+          case (-5): player.getInventory().setHelmet(item);
+          case (-4): player.getInventory().setChestplate(item);


What happens if a user using this slot -4 to set the boots for example or just a random itemStack rather than a chestPlate item?

It would still put that item into that slot as the method forces it i'm pretty sure.

Tigerpanzer02

Add a example kits.yml which contains one kit example e.g. default kit of vd or tb

MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/KitRegistry.java

Tigerpanzer02 · 2023-08-15T21:05:33Z

...sic/src/main/java/plugily/projects/minigamesbox/classic/utils/configuration/ConfigUtils.java

+   * @return       Return value is true if the data value was not set and has now been set.
+   */
+  public static boolean setIfAbsent(FileConfiguration config, String key, Object data) {
+    if (!config.isSet(key) || !config.contains(key) || config.get(key) == null) {


why we got this if its never used?

Lagggpixel · 2023-08-16T03:51:35Z

Changes still needed.

Lagggpixel · 2023-08-18T01:43:23Z

Add a example kits.yml which contains one kit example e.g. default kit of vd or tb

It should be auto generated.

…t items.

MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/basekits/Kit.java

…ox/classic/kits/basekits/Kit.java Co-authored-by: montlikadani <[email protected]>

MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/KitRegistry.java

montlikadani · 2023-09-22T10:58:39Z

MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/KitRegistry.java

+      configurationSection.set("display_item", XItemStack.serialize(new ItemStack(Material.BEDROCK)));
+    }
+
+    ItemStack itemStack = XItemStack.deserialize(Objects.requireNonNull(configurationSection.getConfigurationSection("display_item")));


Useless Objects.requireNonNull, intellij suggests using it, but the above code set this section if not found

I just want it there so I don't get yellow code 🤣 .

Co-authored-by: montlikadani <[email protected]>

into dev_kitEdit

MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/KitRegistry.java

…ox/classic/kits/KitRegistry.java Co-authored-by: montlikadani <[email protected]>

montlikadani · 2023-09-27T15:57:49Z

MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/KitRegistry.java

+    if (configurationSection.getString("unlockedOnDefault") == null) {
+      plugin.getDebugger().debug(Level.SEVERE, "Kit " + kit_key + " does not have an unlockedOnDefault configuration.");
+      plugin.getDebugger().debug(Level.SEVERE, "Kit" + kit_key + " will not be loaded.");
+      return;
+    }
+    kit.setUnlockedOnDefault(configurationSection.getBoolean("unlockedOnDefault"));


I would not print a warning because of this missing unlockedOnDefault property, I would just specify a default value for this boolean. If this property missing from the config, it will return the default value, pretty useless and dumb users might also ask "what is this error" as usual

unlockOnDefault is a value set for all default kits.yml

So if you set up the kits properly, it should print anything in console.

sonarqubecloud · 2023-10-10T20:37:23Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
14 Code Smells

No Coverage information
0.0% Duplication

…y mechanic | Fixed player chat issue & more (#32) * Bump version from 1.3.1 to 1.3.1-SNAPSHOT0 * Fixed doubled statistics, which result in 0 placeholders * Bump version from 1.3.1-SNAPSHOT0 to 1.3.1-SNAPSHOT1 * Bump version from 1.3.2 to 1.3.2-SNAPSHOT0 * Fixed bossbar did not disable (config option) * added default poms for maven building * Bump version from 1.3.2-SNAPSHOT0 to 1.3.2-SNAPSHOT1 * fixed rewards enabling * Bump version from 1.3.2-SNAPSHOT1 to 1.3.2-SNAPSHOT2 * Fixed locale registration if services are unavailable * fixed version * Bump version from 1.3.2-SNAPSHOT2 to 1.3.2-SNAPSHOT3 * Added SEPARATE_ARENA_SPECTATORS * Bump version from 1.3.2-SNAPSHOT3 to 1.3.2-SNAPSHOT4 * Fixed NPE on command usage /pluginindicator stop * Bump version from 1.3.2-SNAPSHOT4 to 1.3.2-SNAPSHOT5 * Support 1.20.2 * Bump version from 1.3.2-SNAPSHOT5 to 1.3.2-SNAPSHOT6 * prepared kits.yml file upgrade * Bump version from 1.3.2-SNAPSHOT6 to 1.3.2-SNAPSHOT7 * Kit editing (#31) * feat: added setIfAbsent method to ConfigUtils * Minor kit update. * feat: kits config foundation * Revert "feat: kits config foundation" This reverts commit 90b140d. * Java 8 compactible * Resolved 1 review. #31 (comment) * Removed 1 unnecessary method. * Moved initialize kit config to after checking if kit is enabled. * Reformatted code * Removed setting name to the config file * Reformatted inventory section of configuration file for kits.yml * Reformatted armour section of configuration file for kits.yml * Added kit item handling, allowing items to be changed while giving kit items. * Update .gitignore * Updated snapshot version * Removed Kit.restock() method. * Removed Kit.restock() method. * Fix for a NPE * Fix for another NPE * Fix for another another NPE * Bumped snapshot version * Update MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/basekits/Kit.java Co-authored-by: montlikadani <[email protected]> * Update for level kits. * Updated structure of kit loading and handling * Fixed getting the itemstack on display for the kit menu * Fixed default kit * Fixed clone kit * Merged suggestion on key_name. Co-authored-by: montlikadani <[email protected]> * Restructured code * Updated KitMenuHandler.java * Updated version * Modified how KitRegistry.handleItem is used. * Create HandleItem.java * Modified handleitem interface * Fixed optional configuration values * Update MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/KitRegistry.java Co-authored-by: montlikadani <[email protected]> --------- Co-authored-by: montlikadani <[email protected]> Co-authored-by: Tigerpanzer_02 <[email protected]> * Bump version from 1.3.2-SNAPSHOT13 to 1.3.2-SNAPSHOT14 * Added method to move full hologramarmorstand * Bump version from 1.3.2-SNAPSHOT14 to 1.3.2-SNAPSHOT15 * Fixed kits startup issues * Added kits description * Added KitAction NO_AMOUR * Fixed kit name and lore on kitmenu * Fixed colour on KitMenuItems * Bump version from 1.3.2-SNAPSHOT15 to 1.3.2-SNAPSHOT16 * Fixed player name on chat is removed while PAPI enabled * Bump version from 1.3.2-SNAPSHOT16 to 1.3.2-SNAPSHOT17 * Fixed SelectKitArgument showing for plugins without kits * Bump version from 1.3.2-SNAPSHOT17 to 1.3.2-SNAPSHOT18 * Moved KitAction to KitAbility * Added kit restock method, should be used with optional configuration * Allow plugin specific KitAbilities Added KitAbilityManager Added ArmorHelper.getArmorTypes * Bump version from 1.3.2-SNAPSHOT18 to 1.3.2-SNAPSHOT19 * Renamed actions to abilities in kits.yml * Bump version from 1.3.2-SNAPSHOT19 to 1.3.2-SNAPSHOT20 --------- Co-authored-by: version-bump[github-action] <41898282+version-bump[github-action]@users.noreply.github.com> Co-authored-by: Wanbin Cao <[email protected]> Co-authored-by: montlikadani <[email protected]>

Lagggpixel and others added 5 commits August 9, 2023 23:44

feat: added setIfAbsent method to ConfigUtils

d4620b2

Minor kit update.

fc71112

Merge branch 'Plugily-Projects:master' into dev_kitEdit

259eeb6

Merge branch 'development' into dev_kitEdit

2cb9b1c

feat: kits config foundation

90b140d

montlikadani reviewed Aug 13, 2023

View reviewed changes

...ox Classic/src/main/java/plugily/projects/minigamesbox/classic/utils/helper/ArmorHelper.java Outdated Show resolved Hide resolved

montlikadani reviewed Aug 13, 2023

View reviewed changes

MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/basekits/Kit.java Outdated Show resolved Hide resolved

montlikadani reviewed Aug 13, 2023

View reviewed changes

MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/basekits/Kit.java Outdated Show resolved Hide resolved

montlikadani reviewed Aug 13, 2023

View reviewed changes

MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/KitRegistry.java Outdated Show resolved Hide resolved

Lagggpixel added 3 commits August 14, 2023 23:45

Revert "feat: kits config foundation"

f5a3f57

This reverts commit 90b140d.

Java 8 compactible

6a740a0

Resolved 1 review.

2d92e26

#31 (comment)

montlikadani reviewed Aug 15, 2023

View reviewed changes

Tigerpanzer02 requested changes Aug 15, 2023

View reviewed changes

Lagggpixel added 4 commits August 16, 2023 08:58

Removed 1 unnecessary method.

1eb5a69

Moved initialize kit config to after checking if kit is enabled.

227ea09

Reformatted code

9f2b5c7

Removed setting name to the config file

31da022

Lagggpixel added 2 commits August 16, 2023 12:15

Reformatted inventory section of configuration file for kits.yml

ec6ef46

Reformatted armour section of configuration file for kits.yml

b465798

Lagggpixel requested a review from Tigerpanzer02 August 17, 2023 05:09

Lagggpixel added 5 commits August 26, 2023 10:03

Added kit item handling, allowing items to be changed while giving ki…

e1c3892

…t items.

Update .gitignore

f167035

Updated snapshot version

4572f9b

Removed Kit.restock() method.

9245a0d

Removed Kit.restock() method.

85b5fbc

Lagggpixel added 3 commits August 26, 2023 12:45

Fix for another NPE

8ca692e

Fix for another another NPE

4149775

Bumped snapshot version

2bcf610

montlikadani reviewed Aug 26, 2023

View reviewed changes

MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/basekits/Kit.java Outdated Show resolved Hide resolved

Lagggpixel and others added 6 commits August 26, 2023 15:37

Update MiniGamesBox Classic/src/main/java/plugily/projects/minigamesb…

22582e4

…ox/classic/kits/basekits/Kit.java Co-authored-by: montlikadani <[email protected]>

Update for level kits.

2ce165b

Updated structure of kit loading and handling

c272aeb

Fixed getting the itemstack on display for the kit menu

fed38b9

Fixed default kit

bc3e5a0

Fixed clone kit

d960b92

montlikadani reviewed Sep 22, 2023

View reviewed changes

MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/KitRegistry.java Outdated Show resolved Hide resolved

montlikadani reviewed Sep 22, 2023

View reviewed changes

Lagggpixel and others added 9 commits September 22, 2023 14:44

Merge branch 'development' into dev_kitEdit

6bdc46d

Merged suggestion on key_name.

bb51e6e

Co-authored-by: montlikadani <[email protected]>

Restructured code

90335d4

Merge branch 'dev_kitEdit' of https://github.com/Lagggpixel/MiniGamesBox

804fcab

into dev_kitEdit

Updated KitMenuHandler.java

f4fc006

Updated version

0cd16ec

Modified how KitRegistry.handleItem is used.

34641b3

Create HandleItem.java

5dc2315

Modified handleitem interface

5f42f21

montlikadani reviewed Sep 27, 2023

View reviewed changes

MiniGamesBox Classic/src/main/java/plugily/projects/minigamesbox/classic/kits/KitRegistry.java Outdated Show resolved Hide resolved

Lagggpixel and others added 2 commits September 27, 2023 16:55

Fixed optional configuration values

94a3a35

Update MiniGamesBox Classic/src/main/java/plugily/projects/minigamesb…

b41b95b

…ox/classic/kits/KitRegistry.java Co-authored-by: montlikadani <[email protected]>

montlikadani reviewed Sep 27, 2023

View reviewed changes

Merge branch 'development' into dev_kitEdit

82fc8dc

Tigerpanzer02 merged commit 71031a1 into Plugily-Projects:development Oct 10, 2023

Lagggpixel deleted the dev_kitEdit branch October 10, 2023 20:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kit editing #31

Kit editing #31

Lagggpixel commented Aug 13, 2023

Lagggpixel commented Aug 13, 2023

montlikadani Aug 13, 2023

Lagggpixel Aug 15, 2023

montlikadani Aug 15, 2023

Tigerpanzer02 Aug 15, 2023

montlikadani Aug 16, 2023

montlikadani Aug 15, 2023

Lagggpixel Aug 15, 2023

Tigerpanzer02 left a comment

Tigerpanzer02 Aug 15, 2023

Lagggpixel commented Aug 16, 2023

Lagggpixel commented Aug 18, 2023

montlikadani Sep 22, 2023

Lagggpixel Sep 22, 2023

montlikadani Sep 27, 2023

Lagggpixel Sep 28, 2023

Lagggpixel Sep 28, 2023

sonarqubecloud bot commented Oct 10, 2023

Kit editing #31

Kit editing #31

Conversation

Lagggpixel commented Aug 13, 2023

Lagggpixel commented Aug 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tigerpanzer02 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Lagggpixel commented Aug 16, 2023

Lagggpixel commented Aug 18, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Oct 10, 2023