Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kit editing #31
Kit editing #31
Changes from 5 commits
d4620b2
fc71112
259eeb6
2cb9b1c
90b140d
f5a3f57
6a740a0
2d92e26
1eb5a69
227ea09
9f2b5c7
31da022
ec6ef46
b465798
e1c3892
f167035
4572f9b
9245a0d
85b5fbc
00fd8f2
8ca692e
4149775
2bcf610
22582e4
2ce165b
c272aeb
fed38b9
bc3e5a0
d960b92
6bdc46d
bb51e6e
90335d4
804fcab
f4fc006
0cd16ec
34641b3
5dc2315
5f42f21
94a3a35
b41b95b
82fc8dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 3 condition literally doing the same check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundancy in case one of them breaks for some random reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt it, using the
get
method is completely sufficient. If you want a deep check, you can use theisSet
method as this checks to copy the default value or not.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we got this if its never used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I didn't even see it isn't used