-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] simplify and unify the storage setup for tests #2590
base: staging
Are you sure you want to change the base?
[Refactor] simplify and unify the storage setup for tests #2590
Conversation
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
ef9c5ea
to
6868d4b
Compare
While that one program ( For reference, this is the one mismatch:
|
I have a branch ready with a |
Update: I no longer have that one test mismatch with updated |
Signed-off-by: ljedrz <[email protected]>
I updated the PR to use a new |
The hybrid nature of our storage makes testing it tricky, and there are several spots where we are currently using a mix of in-memory and persistent storage, which complicates things further. The changes proposed in this PR are something that I've hoped to see in snarkVM for a while now, and since some other, concurrent snarkVM work requires a stricter separation between the storage variants, it was a good opportunity to finally propose them.
The following is a rough summary of these changes:
open_(.*)testing
methods are no longer needed, there is no test special-casing for rocksdb eitheropen
methods no longer requireS
to beClone
static DB
, there is now astatic DATABASES
, which has more than a single member only in testsledger-with-rocksdb
CI job should be runnable againFuture improvements:
open
methods for the stores didn't rely so much onStorageMode
(i.e. if we could use an instance of actual storage to open the stores), we wouldn't needstatic DATABASES
(orDB
, as is the case currently); that being said, I'd prefer it to be done separatelyRequires: ProvableHQ/aleo-std#12