Bump python-engineio #8099
Bump python-engineio #8099
Conversation
|
Thanks for submitting a pull request 🚀 @b-quachtran will take a look at it as soon as possible ✨ |
| @@ -101,8 +101,8 @@ multidict = "^4.6" | |||
| aiohttp = "~3.6" | |||
| questionary = "~1.5.1" | |||
| prompt-toolkit = "^2.0" | |||
| python-socketio = ">=4.4,<6" | |||
| python-engineio = ">=3.11,<3.14" | |||
| python-socketio = ">=5,<6" | |||
There was a problem hiding this comment.
is there a specific reason we need to change the python-socketio version range?
| python-socketio = ">=4.4,<6" | ||
| python-engineio = ">=3.11,<3.14" | ||
| python-socketio = ">=5,<6" | ||
| python-engineio = ">=4,<5" |
There was a problem hiding this comment.
is there a specific reason we have to increase the minimum bound?
There was a problem hiding this comment.
Because of >=4.4,<6, python-socketio accidentally got bumped to 5, which is incompatible with python-engineio >=3.11,<3.14. python-socketio and python-engineio need to be in lockstep, as explained by rgstephens here: botfront/rasa-webchat#344
There was a problem hiding this comment.
Sure, but can't poetry handle finding compatible versions if there exists a valid overlap?
There was a problem hiding this comment.
That would have been the hope, but there's no denying something went wrong here.
There was a problem hiding this comment.
python-socketio 5.0.0 had bad deps, that only got corrected in 5.0.1.. This means the current pyproject.toml will always resolve to this incompatible situation (python-socketio 5.0.0 with python-engineio 3.13.2). Either you bump (like I did), or you downgrade.
There was a problem hiding this comment.
ok I see 👍
Would it be possible to just exclude python-socketio 5.0.0?
We would like to be able to keep a wider range.
|
fixed as part of #8343 |
Fixes #8092
Status (please check what you already did):