Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python-engineio #8099

Closed
wants to merge 8 commits into from
Closed

Bump python-engineio #8099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6420f0b
bump python-engineio
pheel Mar 3, 2021
e7ff7b4
changelog
pheel Mar 3, 2021
24a4d90
Merge branch 'main' into bump-python-engineio
pheel Mar 3, 2021
be72e4d
Merge branch 'main' into bump-python-engineio
b-quachtran Mar 4, 2021
83ab310
Merge branch 'main' into bump-python-engineio
pheel Mar 5, 2021
eb2e862
Merge branch 'main' into bump-python-engineio
pheel Mar 7, 2021
64e074f
Merge branch 'main' into bump-python-engineio
b-quachtran Mar 9, 2021
bffe172
Merge branch 'main' into bump-python-engineio
pheel Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/8099.bugfix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Bump `python-engineio` to 4.0 to make it compatible with `python-socketio` 5.0.
53 changes: 42 additions & 11 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ multidict = "^4.6"
aiohttp = "~3.6"
questionary = "~1.5.1"
prompt-toolkit = "^2.0"
python-socketio = ">=4.4,<6"
python-engineio = ">=3.11,<3.14"
python-socketio = ">=5,<6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a specific reason we need to change the python-socketio version range?

python-engineio = ">=4,<5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a specific reason we have to increase the minimum bound?

Copy link
Contributor Author

@pheel pheel Mar 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of >=4.4,<6, python-socketio accidentally got bumped to 5, which is incompatible with python-engineio >=3.11,<3.14. python-socketio and python-engineio need to be in lockstep, as explained by rgstephens here: botfront/rasa-webchat#344

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but can't poetry handle finding compatible versions if there exists a valid overlap?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would have been the hope, but there's no denying something went wrong here.

Copy link
Contributor Author

@pheel pheel Mar 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python-socketio 5.0.0 had bad deps, that only got corrected in 5.0.1.. This means the current pyproject.toml will always resolve to this incompatible situation (python-socketio 5.0.0 with python-engineio 3.13.2). Either you bump (like I did), or you downgrade.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I see 👍
Would it be possible to just exclude python-socketio 5.0.0?
We would like to be able to keep a wider range.

pydot = "~1.4"
async_generator = "~1.10"
SQLAlchemy = "~1.3.3"
Expand Down