takeoff_move_and_land example responses updated #7
Conversation
Hardcoded IP is changed to 127.0.0.1 because out of the box, UE instance runs on local machine. All boolean responses will reuse mutable res variable. client_arm_disarm line was using confirm_connection operation's response. It uses its own response now. Response assignments are added for operations like geo move, go home and landing. These are done because the operations won't return true (complete successfully) in each call. For example, go_home_async returns false but info says "got home".
|
I didn't want to change nature of the examples, just minor fixes and refactoring. I will try to check other examples with same lens when I have time. |
There was a problem hiding this comment.
Added some nit comments, other than that it looks good. Let me know when you have made the chances and I'll approve it :)
Also, I think we should probably add a few tasks to the Kanban board I just created so that it is easier to track roadmap and progress of tasks. It also helps us to have a common understanding of what needs to be done. Feel free to add cards :) https://github.com/users/Sollimann/projects/1
Kanban board link gives 404 error. |
|
You should have access now |
1 similar comment
|
You should have access now |
|
I'm currently on vacation, but will have a look again when I'm back in front of a computer :) |
Hardcoded IP is changed to 127.0.0.1 because out of the box, UE instance runs on local machine.
All boolean responses will reuse mutable res variable.
client_arm_disarm line was using confirm_connection operation's response. It uses its own response now.
Response assignments are added for operations like geo move, go home and landing. These are done because the operations won't return true (complete successfully) in each call. For example, go_home_async returns false but info says "got home".