Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small changes to help typing #283

Merged
merged 20 commits into from
Oct 22, 2024
Merged

small changes to help typing #283

merged 20 commits into from
Oct 22, 2024

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Oct 10, 2024

Removed unused stuff

  • CamelCaseConfigParser default in init
  • MultipleValuesException remove default Nones

Renaming variables to help mypy

  • match to full_match

Initialise with a fake value rather than None to avoid Optional and assert Not None

Change the order of params so one can be non optional

Wrap an Iterable[str] with list

  • This is needed as Itertable[str] can be both a str or a list of Str so the typer must use MutableSequence[str]

Return None directly

  • rather than setting a temp value None and the returning that

raise an exception at the end of methods that should have already returned

@Christian-B Christian-B mentioned this pull request Oct 17, 2024
@Christian-B Christian-B merged commit c677cdf into master Oct 22, 2024
10 checks passed
@Christian-B Christian-B deleted the remove_unused branch October 22, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants