Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kathy first draft for TR1 #357

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Kathy first draft for TR1 #357

wants to merge 7 commits into from

Conversation

kathypinzon
Copy link

first half of TR1 ready... the angles aren't working in sage though.

@StevenClontz
Copy link
Contributor

Click the red X to see the error:

PTX:ERROR:      The @xml:id "90 degree angle" is invalid.  Use only letters, numbers, hyphens and underscores.

Please push an update with IDs of the form 90-degree-angle or 90_degree_angle.

@StevenClontz StevenClontz marked this pull request as draft October 15, 2024 14:06
Copy link

🚀 Preview available 🚀

https://9106eca7.tbil.pages.dev

Copy link

🚀 Preview available 🚀

https://d6c9cc49.tbil.pages.dev

Copy link

🚀 Preview available 🚀

https://9df2f40e.tbil.pages.dev

Copy link

🚀 Preview available 🚀

https://5cdd3496.tbil.pages.dev

Comment on lines +105 to +112
<figure xml:id="standard-position"><image width="50%">
<sageplot>
p=arrow((0,0),(4,0),aspect_ratio=1)
p+=arrow((0,0),(-3,-3))
p+=arc((0,0),0.5,sector=(0, 5*pi/4),color="black")
p
</sageplot>
</image></figure>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StevenClontz We want to have the axes show up on this one, but no tickmarks or tickmark labels. Do you know how to do that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I figured it out. The key is to past a list of two empty lists (ticks=[[],[]]), rather than ticks=None like I was trying.

Suggested change
<figure xml:id="standard-position"><image width="50%">
<sageplot>
p=arrow((0,0),(4,0),aspect_ratio=1)
p+=arrow((0,0),(-3,-3))
p+=arc((0,0),0.5,sector=(0, 5*pi/4),color="black")
p
</sageplot>
</image></figure>
<figure xml:id="standard-position"><image width="50%">
<sageplot>
p=arrow((0,0),(4,0),aspect_ratio=1,ticks=[[],[]])
p+=arrow((0,0),(-3,-3))
p+=arc((0,0),0.5,sector=(0, 5*pi/4),color="black")
p
</sageplot>
</image></figure>

Comment on lines +119 to +124
<sageplot>
p=arrow((0,0),(4,0),aspect_ratio=1)
p+=arrow((0,0),(-3,-3))
p+=arc((0,0),0.5,sector=(5*pi/4,2*pi),color="black")
p
</sageplot>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StevenClontz Same for this one

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<sageplot>
p=arrow((0,0),(4,0),aspect_ratio=1)
p+=arrow((0,0),(-3,-3))
p+=arc((0,0),0.5,sector=(5*pi/4,2*pi),color="black")
p
</sageplot>
<sageplot>
p=arrow((0,0),(4,0),aspect_ratio=1,ticks=[[],[]])
p+=arrow((0,0),(-3,-3))
p+=arc((0,0),0.5,sector=(5*pi/4,2*pi),color="black")
p
</sageplot>

Copy link

🚀 Preview available 🚀

https://93a20e73.tbil.pages.dev

Copy link

🚀 Preview available 🚀

https://ed473318.tbil.pages.dev

@siwelwerd
Copy link
Contributor

siwelwerd commented Oct 29, 2024

@kathypinzon See above for the question you had earlier. You can commit those suggestions, then look at the preview in Codechat. Should look like this (for the first one)

image

If you're happy with that, mark this as ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants