Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trekking.brf #745

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

maciejs
Copy link

@maciejs maciejs commented Dec 4, 2024

@polyscias
Copy link
Contributor

Repeating here what I wrote in #746:

I do think it is not a good idea to set the penalty for foot=use_sidepath to 10000, i.e. the same as no.

Not all Openstreetmap data is correct and especially for short segments around crossings I have seen foot=use_sidepath set incorrectly.

10000 means that brouter will never include the way, instead I suggest to set a high penalty like 100 so the algorithm will still have the option to chose it if there is foot=use_sidepath but no suitable sidepath.

Where for bicycle this is less a problem, as the fall back is pushing the bike i.e. foot with this foot change there is no fall-back.

@quaelnix
Copy link
Collaborator

quaelnix commented Dec 7, 2024

@polyscias, I was also sceptical at first, but this change only affects a small subset of one-way streets, and it does work well.

@polyscias
Copy link
Contributor

If "it works well" is your criteria, 100 also works well:

Screenshot_20241207_142814

@quaelnix
Copy link
Collaborator

quaelnix commented Dec 7, 2024

I think 10000 is acceptable in this case, but I would also agree with 100. However, the routing and code example you showed belongs to: #746

@maciejs
Copy link
Author

maciejs commented Dec 23, 2024

@polyscias @quaelnix Thank you for your suggestions, I have updated the value

@quaelnix
Copy link
Collaborator

@afischerdev, are you ok with this change?

@afischerdev
Copy link
Collaborator

afischerdev commented Dec 28, 2024

@quaelnix
I don't mind. But the result looks different to the sample above

I could merge if wanted. So we could go on with #753, #743

@maciejs
Copy link
Author

maciejs commented Dec 29, 2024

@quaelnix I don't mind. But the result looks different to the sample above

I'm not sure if this was an actual change proposal or just for demo, @polyscias could you clarify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants