-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trekking.brf #745
base: master
Are you sure you want to change the base?
Update trekking.brf #745
Conversation
Repeating here what I wrote in #746: I do think it is not a good idea to set the penalty for foot=use_sidepath to 10000, i.e. the same as no. Not all Openstreetmap data is correct and especially for short segments around crossings I have seen foot=use_sidepath set incorrectly. 10000 means that brouter will never include the way, instead I suggest to set a high penalty like 100 so the algorithm will still have the option to chose it if there is foot=use_sidepath but no suitable sidepath. Where for bicycle this is less a problem, as the fall back is pushing the bike i.e. foot with this foot change there is no fall-back. |
@polyscias, I was also sceptical at first, but this change only affects a small subset of one-way streets, and it does work well. |
I think 10000 is acceptable in this case, but I would also agree with 100. However, the routing and code example you showed belongs to: #746 |
@polyscias @quaelnix Thank you for your suggestions, I have updated the value |
@afischerdev, are you ok with this change? |
@quaelnix |
I'm not sure if this was an actual change proposal or just for demo, @polyscias could you clarify? |
#743