Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hiking-mountain.brf #746

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maciejs
Copy link

@maciejs maciejs commented Dec 5, 2024

@quaelnix
Copy link
Collaborator

quaelnix commented Dec 7, 2024

It seems to work reasonably well.

@polyscias
Copy link
Contributor

I do think it is not a good idea to set the penalty for foot=use_sidepath to 10000, i.e. the same as no.

Not all Openstreetmap data is correct and especially for short segments around crossings I have seen foot=use_sidepath set incorrectly.

10000 means that brouter will never include the way, instead I suggest to set a high penalty like 100 so the algorithm will still have the option to chose it if there is foot=use_sidepath but no suitable sidepath.

Where for bicycle this is less a problem, as the fall back is pushing the bike i.e. foot with this foot change there is no fall-back.

@polyscias polyscias mentioned this pull request Dec 7, 2024
@quaelnix
Copy link
Collaborator

quaelnix commented Dec 7, 2024

@polyscias, I was also sceptical at first, but this change does not seem to completely remove these ways from the routing graph.

You are right, the only reason it seems to have worked well, is, that bikeaccess is usually true on such segments. Otherwise these segments would would have been removed from the routing graph, which is - as you said - not a good idea. But the solution you proposed: #745 (comment), is also problematic. I would suggest to replace:

assign accesspenalty switch footaccess 0 switch bikeaccess 4 100000

with:

assign accesspenalty switch footaccess 0 switch bikeaccess 4 switch foot=use_sidepath 10 100000

@maciejs
Copy link
Author

maciejs commented Dec 23, 2024

@quaelnix Thank you for your suggestion, I have updated the change

@quaelnix
Copy link
Collaborator

@polyscias, what do you think about the updated version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants