OcPeCoffExtLib: Add support for FixupAppleEfiImages quirk #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth pointing out that the functionality I've implemented seems to overlap somewhat (but not quite enough, I think) with this unused functionality: https://github.com/acidanthera/OpenCorePkg/pull/498/files#diff-a9f15dff840fe93b2f4cad53afc58083d8b3d8638439812968501119926b88a5R913-R917 |
mikebeaton
commented
Nov 2, 2023
|
Code looks perfectly correct to me. |
mikebeaton
force-pushed
the
legacy-efi
branch
2 times, most recently
from
cff6bee to
db6f6c1
Compare
Good code design, obviously! ;) Thank you, though. |
mikebeaton
force-pushed
the
legacy-efi
branch
from
763ca40 to
b6d5baf
Compare
kokowski
pushed a commit
to kokowski/OpenCorePkg
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes acidanthera/bugtracker#2233
For the purposes of viewing the changes, I strongly recommend mikebeaton@b6d5baf (i.e. commit 2/3), since this makes it very clear how OcPeCoffFixup.c relates to PeCoffInit.c which it came from.
Since all three commits are valid builds of OpenCore (with only Uncrustify errors, only in one file, in 1/3 and 2/3), then I suggest it might be worth keeping this three-commit structure in the main branch (i.e. not accepting as a merge commit, but just pushing the tip of this branch to master to accept the changes and auto-close the PR), so that it keeps the reference commit where it's easy to see the changes made between PeCoffInit.c and OcPeCoffFixup.c.