Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/additional serverless deploy permissions #31

Merged
merged 14 commits into from
Dec 5, 2023

Conversation

crispy101
Copy link
Contributor

Additional permisisons as per serverless application behaviour updates

@crispy101 crispy101 requested a review from a team as a code owner December 4, 2023 05:33
Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just need to fix that test

@crispy101
Copy link
Contributor Author

crispy101 commented Dec 4, 2023

@TheOrangePuff Just updated a couple of stuff around testing

  • Test script update to suit the permission change
  • Bump up node version to 18
    Can I ask for another look at the latest commit.

Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crispy101 crispy101 merged commit c2a4fa2 into main Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants