Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/additional serverless deploy permissions #31

Merged
merged 14 commits into from
Dec 5, 2023
Merged

Feature/additional serverless deploy permissions #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e26c5f1
add permissions as per serverless scope updates
Dec 4, 2023
7010a66
fix typo
Dec 4, 2023
1ce6b4b
allow cloudformation:ListExports against all the stacks to match serv…
Dec 4, 2023
cd2a332
add permissions as per serverless scope updates
Dec 4, 2023
fb01efe
add permissions as per serverless scope updates
Dec 4, 2023
45e0890
add permissions as per serverless scope updates
Dec 4, 2023
f0d8c6b
add permissions as per serverless scope updates
Dec 4, 2023
40d4524
add permissions as per serverless scope updates
Dec 4, 2023
4d15158
add permissions as per serverless scope updates
Dec 4, 2023
e014818
add permissions as per serverless scope updates
Dec 4, 2023
00e6339
add permissions as per serverless scope updates
Dec 4, 2023
a3010d1
add permissions as per serverless scope updates
Dec 4, 2023
b64fbd8
add permissions as per serverless scope updates
Dec 4, 2023
e8ba1fa
update test condition to suit the change, and bump up node version of…
Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cdk-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ jobs:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.release.target_commitish }}
- name: Use Node.js 16
- name: Use Node.js 18
uses: actions/setup-node@v1
with:
node-version: 16
node-version: 18
registry-url: https://registry.npmjs.org/
- run: npm ci
- run: npm run test --workspaces
53 changes: 53 additions & 0 deletions packages/serverless-deploy-iam/bin/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,51 @@ export class ServiceDeployIAM extends cdk.Stack {
"cognito-identity:CreateIdentityPool",
"cognito-identity:SetIdentityPoolRoles"
]
},
{
name: 'CLOUDFRONT-OAI',
resources: [
`arn:aws:cloudfront::${accountId}:origin-access-identity/*`
],
actions: [
"cloudfront:CreateCloudFrontOriginAccessIdentity",
"cloudfront:GetCloudFrontOriginAccessIdentity",
"cloudfront:DeleteCloudFrontOriginAccessIdentity"
]
},
{
name: 'CLOUDFRONT-FUNCTION',
resources: [
`arn:aws:cloudfront::${accountId}:function/*`
],
actions: [
"cloudfront:CreateFunction"
]
},
{
name: 'CLOUDFRONT-FUNCTION',
resources: [
`arn:aws:cloudfront::${accountId}:function/${serviceName}*`
],
actions: [
"cloudfront:CreateFunction",
"cloudfront:DescribeFunction",
"cloudfront:DeleteFunction",
"cloudfront:PublishFunction",
"cloudfront:GetFunction"
]
},
{
name: 'CLOUDFRONT-DISTRIBUTION',
resources: [ `arn:aws:cloudfront::${accountId}:distribution/*` ],
actions: [
"cloudfront:CreateDistribution",
"cloudfront:DeleteDistribution",
"cloudfront:GetDistribution",
"cloudfront:ListDistributions",
"cloudfront:UpdateDistribution",
"cloudfront:TagResource"
]
}
]
}
Expand Down Expand Up @@ -437,6 +482,7 @@ export class ServiceDeployIAM extends cdk.Stack {
resources: [`*`],
actions: [
"cloudformation:ValidateTemplate",
"cloudformation:ListExports"
]
},
{
Expand Down Expand Up @@ -514,6 +560,13 @@ export class ServiceDeployIAM extends cdk.Stack {
"apigateway:PATCH",
"apigateway:POST"
]
},
{
name: 'DISTRIBUTION',
resources: [ `arn:aws:cloudfront::${accountId}:distribution/*` ],
actions: [
"cloudfront:CreateInvalidation"
]
}
]
}
Expand Down
5 changes: 4 additions & 1 deletion packages/serverless-deploy-iam/test/deploy-role.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@ describe('Deploy user policy', () => {
PolicyDocument: {
Statement: arrayWith(
objectLike({
Action: "cloudformation:ValidateTemplate",
Action: [
"cloudformation:ValidateTemplate",
"cloudformation:ListExports"
],
Effect: "Allow",
Resource: "*"
}),
Expand Down
Loading