Fix PiP aspect ratio issue #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for PiP aspect ratio issue
|
Tested with a Pixel Fold - not seeing a crash when trying landscape playback now, thank you! |
neelanshsahai
requested changes
Apr 18, 2024
app/src/main/java/com/google/android/samples/socialite/ui/player/VideoPlayerScreen.kt
Outdated
Show resolved
Hide resolved
new fix based off of the player's video size
Spotless
|
LGTM |
SigmanZero
reviewed
Apr 23, 2024
| // set source rect hint, aspect ratio | ||
| if (player != null && player.videoSize.width > 0 && player.videoSize.height > 0) { | ||
| val sourceRect = layoutCoordinates.boundsInWindow().toAndroidRectF().toRect() | ||
| builder.setSourceRectHint(sourceRect) |
There was a problem hiding this comment.
I think ideally, this source rect hint would also be set based on the playback surface's bounds - right? I'm not sure how we can do that though, since the PlayerView is created after we set up the pip modifier, and we use the pip modifier when declaring the PlayerView (i.e. it seems like a chicken and egg situation).
There was a problem hiding this comment.
I had a similar thought - it is definitely worth looking into!
|
Tested with both a landscape and a portrait video, in both landscape and portrait device orientations - fix LGTM, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the PiP issue where the app crashes when the app starts playing a video from landscape mode.