Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-72][Dynamic Task] Remove dynamic task type #16842

Merged
merged 10 commits into from
Dec 5, 2024
Merged

Conversation

SbloodyS
Copy link
Member

Purpose of the pull request

close #16591

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Gallardot
Gallardot previously approved these changes Dec 3, 2024
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove WAIT_TO_RUN state, this state is used by dynamic

Copy link

sonarqubecloud bot commented Dec 5, 2024

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gallardot Gallardot merged commit f56d51c into apache:dev Dec 5, 2024
69 of 70 checks passed
@SbloodyS SbloodyS deleted the dsip_72 branch December 5, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DSIP-72][Dynamic Task] Suggest remove dynamic task type
3 participants