Reconcile chip-sampling functionality in RVPipelines
with GeoDatasets
(#1496)
#2040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR unites the code paths for direct chip sampling and chip sampling during the
chip
stage. Thechip
stage now usesGeoDatasets
to sample chips, while still retaining the ability to filter out chips based on their content (e.g. based on NODATA %).The window sampling configs have also been united such that both
ChipOptions
andGeoDataConfig
now accept the same config:WindowSamplingConfig
.See commits for more details.
Checklist
needs-backport
label if the change should be back-ported to the previous releaseNotes
Despite the major changes, backward compatibility with older model bundles has been retained. This required enhancing
Registry
andupgrade_config()
with the ability to handle config renamings.Testing Instructions
See updated unit and integration tests.
Closes #1496