Fixed Specs, Refactor CSS + Use Berkeley Themes #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use berkeley-dark / berkeley-light as themes * dispense with dept-specific theming for now * current enable the dark theme for testing
* chrome screenshots work * migrate to rack 3 🎉 * add a spec summary function to github CI
cycomachead
changed the title
JTD parses the theme name by splitting on "-"
* standardize on Berkeley_X color schemes * move loading berkeley variables to setup * move loading berkeley customization to custom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the specs weren't loading the CSS at all from what I can tell... so I redid the whole test setup and updated to rack 3.
This PR is currently testing with dark mode.
TODOS: