Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patches 2281 #2314

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Patches 2281 #2314

merged 2 commits into from
Jan 25, 2024

Conversation

pavelbrm
Copy link
Contributor

@pavelbrm pavelbrm commented Jan 25, 2024 •
edited
Loading

Summary

Review and feedback for #2281:

  • Extracted the deletion logic for TLV2;
  • Fixed types and arguments for the deletion logic;
  • Added tests (thanks to extraction).

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@pavelbrm pavelbrm changed the base branch from master to multi-device-improvements January 25, 2024 06:12
@pavelbrm pavelbrm self-assigned this Jan 25, 2024
@pavelbrm pavelbrm mentioned this pull request Jan 25, 2024
Merged
18 tasks
@pavelbrm pavelbrm marked this pull request as ready for review January 25, 2024 06:51
@pavelbrm pavelbrm requested review from clD11 and husobee January 25, 2024 06:57
@husobee husobee merged commit d40819d into multi-device-improvements Jan 25, 2024
2 checks passed
@husobee husobee deleted the patches-2281 branch January 25, 2024 17:49
husobee added a commit that referenced this pull request Jan 31, 2024
@husobee @pavelbrm
multiple device refresh improvements (#2281)
fc29a86 
* updates to delete credentials to only hard delete where request id matches item id

* fix: clean up generated code

* Patches 2281 (#2314)

* fix: review

* test: add tests

* fix: use error for checking expectations

* adding check for not allowing delete if number of active credentials exceeds threshold

updates to multi-device improvements to get active credentials count

fixing delete tlv2 test cases to include new check call

fixing db field for request_id for tlv2 creds table

* review feedback improvements

* more review feedback improvements

* updates to pass time into deleteTLV2

* refactor: provide review feedback (#2325)

---------

Co-authored-by: PavelBrm <[email protected]>
Co-authored-by: Pavel Brm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@husobee husobee husobee approved these changes

@clD11 clD11 Awaiting requested review from clD11

Assignees

@pavelbrm pavelbrm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelbrm @husobee