multiple device refresh improvements

[husobee]

Summary

updates to delete credentials to only hard delete where request id matches item id

Type of Change

• Product feature
• Bug fix
• Performance improvement
• Refactor
• Other

Tested Environments

• Development
• Staging
• Production

Before Requesting Review

• Does your code build cleanly without any errors or warnings?
• Have you used auto closing keywords?
• Have you added tests for new functionality?
• Have validated query efficiency for new database queries?
• Have documented new functionality in README or in comments?
• Have you squashed all intermediate commits?
• Is there a clear title that explains what the PR does?
• Have you used intuitive function, variable and other naming?
• Have you requested security and/or privacy review if needed
• Have you performed a self review of this PR?

Manual Test Plan

[clD11]

Could we add some tests to cover the new functionality/endpoints?

[pavelbrm]

There are a few important bugs in the new code that need to be fixed before this is ready. At the very least, in the order of importance:

• The captured loop variable will result in the same value stored len(slice) times. Plus pointers.
• Pointers to UUIDs need to be replaced with values.

[pavelbrm]

I went ahead and expressed my feedback in #2314. Please read the description and the PR. It addresses the following aspects:

• Expresses the deletion logic so it's testable;
• Added test for the deletion logic so that we can see what's being passed down to the datastore level;
• Fixed types for UUID.

[clD11]

Added some comments, at the minimum can we resolve any marked as issue before approving.

[pavelbrm]

Waiting on the open comments to be addressed before doing the final review.

[github-actions]

The following commits were not verified:
d9f6d1b (unsigned)
d3ae44e (unsigned)
633ff7d (unsigned)
a40fb6c (unsigned)
5012c82 (unsigned)
ff503ec (unsigned)

[github-actions]

[puLL-Merge] - brave-intl/bat-go@2281

Description

This PR makes changes to the controllers.go, credentials.go, credentials_noint_test.go, datastore.go, datastore_test.go, instrumented_datastore.go, mockdatastore.go, and order.go files. It adds a new method for handling the deletion of order item credentials and makes related modifications.

Changes

Changes

• services/skus/controllers.go:

  • Added a new deleteItemCreds method for handling the deletion of credentials for an item.
  • Updated the DeleteOrderCreds method to accept an additional parameter reqID.

• services/skus/credentials.go:

  • Added a constant for maxTLV2ActiveOrderCreds.
  • Updated the DeleteOrderCreds method to accept an additional parameter reqID.
  • Added a new method deleteTLV2 for handling the deletion of time-limited V2 credentials.

• services/skus/credentials_noint_test.go:

  • Added a new test case for the deleteTLV2 method.

• services/skus/datastore.go:

  • Updated the DeleteTimeLimitedV2OrderCredsByOrderTx method to accept an additional parameter itemIDs.
  • Added a new method GetCountActiveOrderCreds for retrieving the count of active order credentials.

• services/skus/datastore_test.go:

  • Added a new test case for the GetCountActiveOrderCreds method.

• services/skus/instrumented_datastore.go:

  • Updated the DeleteTimeLimitedV2OrderCredsByOrderTx method to accept an additional parameter itemIDs.
  • Added instrumented methods for GetCountActiveOrderCreds and GetTLV2Creds.

• services/skus/mockdatastore.go:

  • Updated the DeleteTimeLimitedV2OrderCredsByOrderTx method to accept an additional parameter itemIDs.
  • Added a mock method for GetCountActiveOrderCreds.

• services/skus/order.go:

  • Updated the RenewOrder method to call the updated DeleteOrderCreds method with an additional parameter.

Security Hotspots

N/A