Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress v2 support #58

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Ingress v2 support #58

merged 6 commits into from
Nov 14, 2023

Conversation

arturo-seijas
Copy link
Collaborator

@arturo-seijas arturo-seijas commented Nov 14, 2023

Applicable spec: N/A

Overview

Add ingress v2 support

Rationale

Support for ingress v2 will be needed for integration with the oauthkeeper charm

Juju Events Changes

N/A

Module Changes

New ingress module

Library Changes

Added ingress v2 lib

Checklist

@arturo-seijas arturo-seijas added the trivial This is a trivial PR label Nov 14, 2023
@arturo-seijas arturo-seijas changed the title [DNR] Ingress v2 support Ingress v2 support Nov 14, 2023
@arturo-seijas arturo-seijas marked this pull request as ready for review November 14, 2023 11:53
@arturo-seijas arturo-seijas requested a review from a team as a code owner November 14, 2023 11:53
merkata
merkata previously approved these changes Nov 14, 2023
Copy link
Contributor

@merkata merkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

yanksyoon
yanksyoon previously approved these changes Nov 14, 2023
Copy link
Collaborator

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments! LGTM!

tests/integration/conftest.py Outdated Show resolved Hide resolved
tests/integration/test_ingress.py Outdated Show resolved Hide resolved
tests/integration/test_ingress.py Outdated Show resolved Hide resolved
@arturo-seijas arturo-seijas dismissed stale reviews from yanksyoon and merkata via af6d1ba November 14, 2023 14:05
Copy link
Collaborator

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will create followup PR for renaming fixtures named xxx_related

Copy link
Contributor

Test coverage for 2b77415

Name               Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------
src/agent.py          91      0     12      0   100%
src/charm.py         107      0     18      0   100%
src/cos.py            21      0      0      0   100%
src/ingress.py         9      0      0      0   100%
src/jenkins.py       355      0     68      0   100%
src/state.py         103      0     22      0   100%
src/status.py          6      0      2      0   100%
src/timerange.py      31      0      6      0   100%
--------------------------------------------------------------
TOTAL                723      0    128      0   100%

Static code analysis report

Run started:2023-11-14 14:29:50.898207

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 5584
  Total lines skipped (#nosec): 6
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@arturo-seijas arturo-seijas merged commit cfbbb4d into main Nov 14, 2023
24 checks passed
@arturo-seijas arturo-seijas deleted the ingress-v2-support branch November 14, 2023 15:16
@yanksyoon yanksyoon mentioned this pull request Nov 15, 2023
6 tasks
@arturo-seijas arturo-seijas mentioned this pull request Nov 15, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Libraries: OK trivial This is a trivial PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants