-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingress v2 support #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments! LGTM!
af6d1ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will create followup PR for renaming fixtures named xxx_related
Test coverage for 2b77415
Static code analysis report
|
Applicable spec: N/A
Overview
Add ingress v2 support
Rationale
Support for ingress v2 will be needed for integration with the oauthkeeper charm
Juju Events Changes
N/A
Module Changes
New ingress module
Library Changes
Added ingress v2 lib
Checklist
src-docs
urgent
,trivial
,complex
)