Add plots of bias and variance over time #302
Conversation
Damonamajor
requested review from
dfsnow,
wrridgeway and
jeancochrane
as code owners
….com:ccao-data/model-res-avm into 295-add-plots-of-bias-and-variance-over-time
reports/_setup.qmd
Outdated
| run_id: "2024-03-17-stupefied-maya" | ||
| year: "2024" |
There was a problem hiding this comment.
issue (blocking): It's fine to change this when testing, but let's not actually commit the changes here.
There was a problem hiding this comment.
This was the baseline for 2025. I figured I would update it for this one. Do you want to leave it as 2024?
| geom_line() + | ||
| geom_point() + | ||
| labs( | ||
| x = "Date", |
There was a problem hiding this comment.
suggestion: Let's make all the x-axis labels "Date" instead of "Month" (as below).
reports/performance/_model.qmd
Outdated
|
|
||
| ### Variance Ratio (FMV / Sale Price) | ||
|
|
||
| ```{r _variance_ratio_chart} |
There was a problem hiding this comment.
suggestion: Be sure to disable message outputs from these chunks.
reports/performance/_model.qmd
Outdated
| ### Total FMV and Sale Price Variance | ||
| ```{r _overall_variance_chart} | ||
| ggplot( | ||
| training_data_monthly_long %>% filter(Metric %in% c("variance_sale", "variance_fmv")), |
There was a problem hiding this comment.
suggestion: Let's run this through styler to fix long lines like this.
| ### Distribution of Sales and SSE | ||
|
|
||
| ```{r _distribution_sales_sse_chart} | ||
| ggplot(training_data_monthly, aes(x = date)) + |
There was a problem hiding this comment.
suggestion: Let's flip the color scale on this one so sales are blue (and match the other plot with sales).
Co-authored-by: Dan Snow <[email protected]>
Co-authored-by: Dan Snow <[email protected]>
Co-authored-by: Dan Snow <[email protected]>
Co-authored-by: Dan Snow <[email protected]>
This takes the four charts from the recent presentation and replicates them in the performance report.