feat: add grid gap property for more flexibility #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ethanWallace
requested changes
Jan 15, 2025
|
@ethanWallace apologies, the stories completely slipped my mind. I will separate |
daine
reviewed
Jan 20, 2025
|
|
||
| if (newValue != undefined && !values.includes(newValue)) { | ||
| this.gapTablet = undefined; | ||
| console.error('Not a valid spacing value for gap-tablet.'); |
There was a problem hiding this comment.
For logging errors, we now have a helper util logError https://github.com/cds-snc/gcds-components/blob/main/packages/web/src/utils/utils.ts#L122-L138
|
|
||
| if (newValue != undefined && !values.includes(newValue)) { | ||
| this.gapDesktop = undefined; | ||
| console.error('Not a valid spacing value for gap-desktop.'); |
There was a problem hiding this comment.
Another spot where we can use the logError helper util
Comment on lines
+275
to
+283
| // Handle columns | ||
| setGridProperty(columns, 'columns'); | ||
| setGridProperty(columnsTablet, 'columns', '-tablet'); | ||
| setGridProperty(columnsDesktop, 'columns', '-desktop'); | ||
|
|
||
| // Handle gap | ||
| setGridProperty(gap, 'gap'); | ||
| setGridProperty(gapTablet, 'gap', '-tablet'); | ||
| setGridProperty(gapDesktop, 'gap', '-desktop'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Changes
Adding new
gap,gap-tablet, andgap-desktopproperties to the grid component that will allow users to change the value of the grid gap depending on the viewport and adhere to the vertical rhythm of the new typography.The allowed spacing values for each of the new
gapproperties are:150 | 175 | 200 | 225 | 250 | 300 | 350 | 400 | 450 | 500 | 550 | 600 | 650 | 700 | 750 | 800
Additionally, I manually updated the grid readme to include all grid props. It was previously only loading the grid-col props. The new readme can be found here.
How to test
The new properties can be tested by adding
gap,gap-tablet, orgap-desktopto the grid component with any of the above spacing values. Here is an example that can be used to test:Zenhub ticket
This is the Zenhub ticket for the change.
✅ Token package update required
The token package has been updated to it's latest version
2.1.0.