-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default dashboard plots #198
Comments
I wouldn't miss the greyed out buttons. Additionally, as you already mentioned, it would make renaming plots (xref dask/distributed#4878) easier |
Agree I wouldn't miss the greyed out buttons. |
Once this is done we should also remove this backward compatibility in distributed. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This extension gets its list of dask dashboard plots by querying the dashboard's
individual-plots.json
endpoint. These are then shown to the user as the orange buttons in the extension side bar. If, however, that request toindividual-plots.json
fails, we show a default listing, given by this:dask-labextension/src/dashboard.tsx
Lines 439 to 464 in 365913b
Historically, these default items were useful because we were checking for the
individual-plots.json
from the browser side. This request could fail for a valid dashboard URL (often for CORS-related reasons), and having the fallback meant that we could still iframe useful plots for the user. However, since #159 we are checking forindividual-plots.json
on the server side, which is not subject to the same restrictions as the browser. So as it stands today, the default items are mostly (only?) used to show the greyed out buttons when no dask dashboard is connected.As the dask dashboard evolves, gains new plots, renames things, etc, it has become annoying to keep the default listing up-to-date. Furthermore, different scheduler plugins or distributions of dask could add different dashboards. So there really isn't much guarantee that the default listing is particularly accurate. We should consider removing them entirely, and just show something like a "No dashboard connected" info box.
Would anybody miss the grey buttons?
The text was updated successfully, but these errors were encountered: